-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore(elasticsearch sink): Add documentation and tests about OpenSearch #23603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(elasticsearch sink): Add documentation and tests about OpenSearch #23603
Conversation
512ac9c
to
fd5ab1e
Compare
fd5ab1e
to
c20107d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting the PR. It looks good from a Docs perspective. I'll leave the technical review to the Vector team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Remove trailing spaces
Head branch was pushed to by a user without write access
@drichards-87 @pront Thanks for your review! Apologies for missing cargo vdev fmt. Could you approve the workflows and do quick check again? |
Summary
While vector supports OpenSearch in code, it isn't described enough. Also, there are no tests and documentation. With this PR, I added unit tests and the explanation in the doc.
As a follow-up PR, an integration test for OpenSearch should be added.
Issue: #16761
Vector configuration
How did you test this PR?
make test
make test-docs
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changelog
label to this PR.References
Notes
@vectordotdev/vector
to reach out to us regarding this PR.pre-push
hook, please see this template.cargo fmt --all
cargo clippy --workspace --all-targets -- -D warnings
cargo nextest run --workspace
(alternatively, you can runcargo test --all
)git merge origin master
andgit push
.Cargo.lock
), pleaserun
cargo vdev build licenses
to regenerate the license inventory and commit the changes (if any). More details here.