-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(clickhouse sink): add query_settings to clickhouse sink #22764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a017958
to
a7b55af
Compare
Hi @pront ! Thanks for updating the info about this PR. Is there anything I can add to help with the reviewing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pm5, this looks good overall. Left a small comment.
232c2c0
to
17e0442
Compare
Thanks @pront . Let me know what you think of the current version. |
411a447
to
4440d53
Compare
d48b1dc
to
0f93164
Compare
0f93164
to
9906d10
Compare
I found a problem with |
Please do not force push because I have to review the whole PR every time 😅 |
1720078
to
ffe54be
Compare
I went ahead and merged this @pm5 because I think it's a cool new feature. We have plenty of time until next release if there's something you would like to tweak. Current state LGTM. |
Summary
It PR adds a
query_settings
field in the configuration of clickhouse sink, with a few configurations for asynchronous inserts.Change Type
Is this a breaking change?
How did you test this PR?
I use the following Vector config to test it:
Start ClickHouse, enable asynchronous logs, create a
demo_logs
table:Run Vector. And then check ClickHouse logs for asynchronous inserts:
You should see the queries done by Vector.
Does this PR include user facing changes?
Checklist
make check-all
is a good command to run locally. This check isdefined here. Some of these
checks might not be relevant to your PR. For Rust changes, at the very least you should run:
cargo fmt --all
cargo clippy --workspace --all-targets -- -D warnings
cargo nextest run --workspace
(alternatively, you can runcargo test --all
)Cargo.lock
), pleaserun
dd-rust-license-tool write
to regenerate the license inventory and commit the changes (if any). More details here.References