Skip to content

Conversation

hencrice
Copy link
Contributor

@hencrice hencrice commented May 26, 2022

Made it possible to pass in arbitrary request headers such that we can
set the "json/emf" header when the logs uploaded by this sink are
actually in the Amazon CloudWatch EMF format: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Embedded_Metric_Format_Specification.html#CloudWatch_Embedded_Metric_Format_Specification_structure

Closes #12760

@bits-bot
Copy link

bits-bot commented May 26, 2022

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented May 26, 2022

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 48c4fda
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/6297c72836ac57000a832241

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label May 26, 2022
@hencrice hencrice force-pushed the emf branch 5 times, most recently from 97e1638 to 19fc5cb Compare May 27, 2022 21:38
@hencrice hencrice changed the title feat(cloudwatch): adding emf support enhancement(cloudwatch): add json/emf support May 27, 2022
Made it possible to pass in arbitrary request headers such that we can
set the "json/emf" header when the logs uploaded by this sink are
actually in the Amazon CloudWatch EMF format: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Embedded_Metric_Format_Specification.html#CloudWatch_Embedded_Metric_Format_Specification_structure

Closes vectordotdev#12760
@hencrice hencrice marked this pull request as ready for review June 1, 2022 04:02
@jszwedko jszwedko changed the title enhancement(cloudwatch): add json/emf support enhancement(aws_cloudwatch_logs sink): add json/emf support Jun 1, 2022
@jszwedko jszwedko self-assigned this Jun 1, 2022
@jszwedko jszwedko self-requested a review June 1, 2022 14:47
jszwedko added 2 commits June 1, 2022 09:26
Signed-off-by: Jesse Szwedko <[email protected]>
Signed-off-by: Jesse Szwedko <[email protected]>
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Jun 1, 2022
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @hencrice ! I pushed a couple of tweaks, but this looks good to me! I like how you refactored the smithy client creation to make sure we apply the same settings (tls, proxy, etc.).

@jszwedko jszwedko requested a review from fuchsnj June 1, 2022 16:33
Copy link
Member

@fuchsnj fuchsnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments, but overall looks good.

.tower
.unwrap_with(&TowerRequestConfig::default());
let client = self.create_client(cx.proxy()).await?;
let smithy_client = self.create_smithy_client(cx.proxy()).await?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the 2 smithy_clients being made here could be shared, but I'm not seeing a reasonable way to do that.

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Soak Test Results

Baseline: 7a6f790
Comparison: 1951895
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_datadog_logs 1.45MiB 1.99 100.00% 72.68MiB 2.45MiB 51.16KiB 0 0.0336873 74.13MiB 3.0MiB 62.74KiB 0 0.0403988 False False
datadog_agent_remap_datadog_logs_acks 1.27MiB 1.71 100.00% 74.46MiB 1.32MiB 27.5KiB 0 0.0176581 75.73MiB 3.23MiB 67.6KiB 0 0.0426823 False False
datadog_agent_remap_blackhole_acks 1.0MiB 1.47 100.00% 68.35MiB 5.09MiB 106.25KiB 0 0.0744944 69.35MiB 4.02MiB 84.01KiB 0 0.0579683 False False
datadog_agent_remap_blackhole 758.58KiB 1.09 100.00% 67.89MiB 2.85MiB 59.75KiB 0 0.0420277 68.63MiB 2.97MiB 62.22KiB 0 0.0432822 False False
socket_to_socket_blackhole 55.66KiB 0.4 99.91% 13.6MiB 618.19KiB 12.58KiB 0 0.0443675 13.66MiB 539.92KiB 11.01KiB 0 0.0385955 False False
http_to_http_noack 86.93KiB 0.36 100.00% 23.76MiB 1017.47KiB 20.73KiB 0 0.0418062 23.85MiB 248.1KiB 5.06KiB 0 0.0101579 False False
fluent_elasticsearch 18.75KiB 0.02 91.07% 79.45MiB 545.3KiB 10.98KiB 0 0.00670082 79.47MiB 53.21KiB 1.07KiB 0 0.000653662 False False
syslog_loki 1.99KiB 0.01 9.46% 14.8MiB 692.92KiB 14.12KiB 0 0.0457185 14.8MiB 437.37KiB 8.94KiB 0 0.0288538 False False
splunk_hec_to_splunk_hec_logs_noack 785.88B 0 6.33% 23.84MiB 333.69KiB 6.83KiB 0 0.0136683 23.84MiB 334.02KiB 6.84KiB 0 0.0136813 False False
http_to_http_json 1.02KiB 0 8.52% 23.84MiB 329.62KiB 6.74KiB 0 0.0134969 23.85MiB 327.81KiB 6.69KiB 0 0.0134219 False False
splunk_hec_indexer_ack_blackhole -5.38KiB -0.02 19.45% 23.77MiB 749.26KiB 15.25KiB 0 0.0307781 23.76MiB 769.4KiB 15.65KiB 0 0.0316126 False False
splunk_hec_to_splunk_hec_logs_acks -5.83KiB -0.02 21.04% 23.77MiB 750.31KiB 15.27KiB 0 0.03082 23.76MiB 768.62KiB 15.64KiB 0 0.0315796 False False
syslog_humio_logs -41.42KiB -0.23 100.00% 17.71MiB 360.84KiB 7.39KiB 0 0.0198952 17.67MiB 310.74KiB 6.36KiB 0 0.0171723 False False
http_pipelines_blackhole -13.78KiB -0.29 56.91% 4.6MiB 593.85KiB 12.16KiB 0 0.125995 4.59MiB 616.36KiB 12.57KiB 0 0.131155 False False
http_pipelines_no_grok_blackhole -85.6KiB -0.43 94.29% 19.66MiB 1.42MiB 29.62KiB 0 0.0719626 19.58MiB 1.62MiB 33.86KiB 0 0.0829096 False False
syslog_splunk_hec_logs -113.97KiB -0.62 100.00% 18.04MiB 164.59KiB 3.36KiB 0 0.00890751 17.93MiB 170.32KiB 3.48KiB 0 0.00927477 False False
http_pipelines_blackhole_acks -31.44KiB -0.66 94.81% 4.62MiB 554.59KiB 11.35KiB 0 0.117136 4.59MiB 563.56KiB 11.51KiB 0 0.119825 False False
splunk_transforms_splunk3 -101.83KiB -0.73 87.51% 13.61MiB 2.25MiB 47.08KiB 0 0.165618 13.51MiB 2.23MiB 46.75KiB 0 0.165308 False False
http_to_http_acks -142.13KiB -0.78 46.24% 17.9MiB 8.02MiB 167.71KiB 0 0.447954 17.76MiB 7.57MiB 158.19KiB 0 0.426012 True True
syslog_regex_logs2metric_ddmetrics -129.72KiB -0.98 100.00% 12.97MiB 610.48KiB 12.44KiB 0 0.0459552 12.84MiB 750.92KiB 15.27KiB 0 0.0570846 False False
syslog_log2metric_humio_metrics -127.86KiB -1.04 100.00% 12.01MiB 422.78KiB 8.62KiB 0 0.0343568 11.89MiB 267.34KiB 5.48KiB 0 0.021953 False False
splunk_hec_route_s3 -230.03KiB -1.15 99.96% 19.62MiB 2.16MiB 45.11KiB 0 0.109986 19.39MiB 2.19MiB 45.82KiB 0 0.113004 False False
syslog_log2metric_splunk_hec_metrics -273.09KiB -1.97 100.00% 13.51MiB 501.59KiB 10.22KiB 0 0.0362373 13.25MiB 349.33KiB 7.12KiB 0 0.0257456 False False

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Soak Test Results

Baseline: 7a6f790
Comparison: 430cb8d
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
splunk_hec_route_s3 872.75KiB 4.46 100.00% 19.11MiB 2.51MiB 52.56KiB 0 0.131548 19.96MiB 2.19MiB 45.67KiB 0 0.10943 False False
datadog_agent_remap_datadog_logs 1.31MiB 1.76 100.00% 74.52MiB 3.33MiB 69.58KiB 0 0.0447335 75.83MiB 4.32MiB 90.19KiB 0 0.056956 False False
datadog_agent_remap_datadog_logs_acks 1.14MiB 1.55 100.00% 73.26MiB 972.92KiB 19.87KiB 0 0.0129658 74.4MiB 4.14MiB 86.47KiB 0 0.0556036 False False
datadog_agent_remap_blackhole 419.01KiB 0.59 100.00% 68.82MiB 1.46MiB 30.68KiB 0 0.0212807 69.23MiB 1.3MiB 27.19KiB 0 0.0187433 False False
datadog_agent_remap_blackhole_acks 365.74KiB 0.51 100.00% 70.64MiB 3.15MiB 65.73KiB 0 0.0445699 71.0MiB 2.21MiB 46.18KiB 0 0.0311295 False False
socket_to_socket_blackhole 58.63KiB 0.42 99.97% 13.68MiB 567.57KiB 11.56KiB 0 0.040507 13.74MiB 545.93KiB 11.14KiB 0 0.0388002 False False
http_to_http_noack 78.22KiB 0.32 99.99% 23.77MiB 970.38KiB 19.77KiB 0 0.0398576 23.85MiB 244.38KiB 4.99KiB 0 0.0100055 False False
syslog_loki 8.52KiB 0.06 49.94% 14.91MiB 547.41KiB 11.15KiB 0 0.0358435 14.92MiB 291.5KiB 5.96KiB 0 0.0190764 False False
fluent_elasticsearch 16.64KiB 0.02 92.54% 79.46MiB 459.88KiB 9.27KiB 0 0.00565101 79.47MiB 53.4KiB 1.08KiB 0 0.000656101 False False
http_to_http_json 2.72KiB 0.01 20.24% 23.84MiB 376.84KiB 7.7KiB 0 0.0154355 23.84MiB 356.94KiB 7.29KiB 0 0.0146191 False False
splunk_hec_to_splunk_hec_logs_noack -45.84B -0 0.37% 23.84MiB 335.57KiB 6.87KiB 0 0.0137445 23.84MiB 336.45KiB 6.89KiB 0 0.0137807 False False
syslog_humio_logs -7.54KiB -0.04 13.05% 17.03MiB 1.6MiB 33.68KiB 0 0.0941969 17.02MiB 1.49MiB 31.16KiB 0 0.0873669 False False
splunk_hec_to_splunk_hec_logs_acks -15.35KiB -0.06 51.45% 23.77MiB 735.52KiB 14.97KiB 0 0.0302087 23.76MiB 793.07KiB 16.13KiB 0 0.0325929 False False
splunk_hec_indexer_ack_blackhole -15.64KiB -0.06 52.55% 23.77MiB 729.2KiB 14.84KiB 0 0.0299464 23.76MiB 789.27KiB 16.05KiB 0 0.0324344 False False
syslog_splunk_hec_logs -26.81KiB -0.15 91.70% 17.51MiB 523.12KiB 10.68KiB 0 0.0291752 17.48MiB 546.68KiB 11.18KiB 0 0.0305349 False False
http_pipelines_blackhole_acks -8.19KiB -0.18 38.82% 4.34MiB 555.21KiB 11.35KiB 0 0.124965 4.33MiB 561.23KiB 11.47KiB 0 0.126553 False False
splunk_transforms_splunk3 -28.31KiB -0.2 32.93% 13.68MiB 2.28MiB 47.59KiB 0 0.166566 13.65MiB 2.22MiB 46.59KiB 0 0.16291 False False
http_pipelines_blackhole -12.91KiB -0.27 55.72% 4.68MiB 562.82KiB 11.53KiB 0 0.117436 4.67MiB 600.27KiB 12.25KiB 0 0.125589 False False
http_pipelines_no_grok_blackhole -62.28KiB -0.32 78.51% 19.3MiB 1.67MiB 35.02KiB 0 0.0866949 19.24MiB 1.72MiB 35.99KiB 0 0.0896116 False False
http_to_http_acks -165.12KiB -0.9 52.44% 17.82MiB 7.59MiB 158.77KiB 0 0.426049 17.66MiB 8.06MiB 168.4KiB 0 0.456118 True True
syslog_log2metric_humio_metrics -124.45KiB -1.01 100.00% 12.0MiB 380.27KiB 7.75KiB 0 0.0309349 11.88MiB 194.81KiB 3.99KiB 0 0.0160094 False False
syslog_regex_logs2metric_ddmetrics -136.81KiB -1.02 100.00% 13.04MiB 671.18KiB 13.67KiB 0 0.0502364 12.91MiB 742.84KiB 15.11KiB 0 0.0561753 False False
syslog_log2metric_splunk_hec_metrics -218.42KiB -1.61 100.00% 13.26MiB 521.96KiB 10.63KiB 0 0.038428 13.05MiB 404.23KiB 8.24KiB 0 0.0302468 False False

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Soak Test Results

Baseline: 7a6f790
Comparison: e2d1152
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_datadog_logs 1.43MiB 1.91 100.00% 74.68MiB 2.41MiB 50.28KiB 0 0.0322321 76.1MiB 3.43MiB 71.82KiB 0 0.0451045 False False
datadog_agent_remap_datadog_logs_acks 1.05MiB 1.45 100.00% 72.11MiB 2.2MiB 46.08KiB 0 0.03054 73.15MiB 4.45MiB 92.91KiB 0 0.0608134 False False
datadog_agent_remap_blackhole_acks 920.84KiB 1.27 100.00% 70.57MiB 3.74MiB 78.09KiB 0 0.0530217 71.47MiB 2.27MiB 47.52KiB 0 0.031822 False False
socket_to_socket_blackhole 146.16KiB 1.03 100.00% 13.91MiB 519.77KiB 10.59KiB 0 0.0364871 14.05MiB 369.45KiB 7.55KiB 0 0.0256714 False False
datadog_agent_remap_blackhole 425.27KiB 0.6 100.00% 69.16MiB 1.91MiB 40.03KiB 0 0.0276205 69.57MiB 1.93MiB 40.38KiB 0 0.0276696 False False
syslog_loki 80.8KiB 0.54 100.00% 14.66MiB 581.22KiB 11.85KiB 0 0.038713 14.74MiB 456.93KiB 9.33KiB 0 0.0302711 False False
http_to_http_noack 59.37KiB 0.24 99.88% 23.79MiB 861.91KiB 17.57KiB 0 0.035378 23.84MiB 243.03KiB 4.96KiB 0 0.00995118 False False
http_pipelines_blackhole 9.94KiB 0.22 40.38% 4.45MiB 650.59KiB 13.33KiB 0 0.142771 4.46MiB 647.6KiB 13.21KiB 0 0.141805 False False
http_pipelines_no_grok_blackhole 20.38KiB 0.11 29.43% 18.44MiB 1.76MiB 36.86KiB 0 0.0955664 18.46MiB 1.89MiB 39.42KiB 0 0.10239 False False
fluent_elasticsearch 56.87KiB 0.07 97.05% 79.42MiB 1.27MiB 26.08KiB 0 0.0159322 79.47MiB 53.99KiB 1.09KiB 0 0.000663259 False False
http_to_http_json -647.52B -0 5.22% 23.85MiB 334.93KiB 6.84KiB 0 0.0137138 23.85MiB 333.47KiB 6.81KiB 0 0.0136544 False False
splunk_hec_to_splunk_hec_logs_noack -787.78B -0 6.39% 23.84MiB 329.77KiB 6.75KiB 0 0.0135077 23.84MiB 332.58KiB 6.81KiB 0 0.0136231 False False
splunk_hec_indexer_ack_blackhole -10.3KiB -0.04 36.69% 23.77MiB 729.91KiB 14.86KiB 0 0.0299778 23.76MiB 769.29KiB 15.65KiB 0 0.0316086 False False
splunk_hec_to_splunk_hec_logs_acks -9.74KiB -0.04 33.11% 23.76MiB 772.63KiB 15.72KiB 0 0.0317451 23.75MiB 810.64KiB 16.49KiB 0 0.0333202 False False
splunk_transforms_splunk3 -48.28KiB -0.34 53.52% 13.82MiB 2.23MiB 46.49KiB 0 0.161141 13.77MiB 2.24MiB 46.92KiB 0 0.162675 False False
syslog_splunk_hec_logs -60.75KiB -0.34 99.61% 17.4MiB 727.51KiB 14.85KiB 0 0.0408259 17.34MiB 730.65KiB 14.92KiB 0 0.0411425 False False
syslog_regex_logs2metric_ddmetrics -59.88KiB -0.46 99.67% 12.7MiB 680.26KiB 13.85KiB 0 0.0523034 12.64MiB 735.59KiB 14.97KiB 0 0.0568191 False False
syslog_humio_logs -93.75KiB -0.52 100.00% 17.48MiB 643.92KiB 13.2KiB 0 0.0359571 17.39MiB 672.41KiB 13.76KiB 0 0.0377459 False False
http_pipelines_blackhole_acks -28.56KiB -0.61 92.06% 4.57MiB 558.61KiB 11.43KiB 0 0.119292 4.54MiB 566.72KiB 11.58KiB 0 0.121766 False False
splunk_hec_route_s3 -159.01KiB -0.77 98.95% 20.11MiB 2.09MiB 43.64KiB 0 0.1038 19.95MiB 2.11MiB 44.16KiB 0 0.105835 False False
syslog_log2metric_humio_metrics -153.83KiB -1.22 100.00% 12.32MiB 319.35KiB 6.51KiB 0 0.02531 12.17MiB 110.13KiB 2.25KiB 0 0.00883649 False False
syslog_log2metric_splunk_hec_metrics -221.34KiB -1.59 100.00% 13.56MiB 623.25KiB 12.68KiB 0 0.0448841 13.34MiB 518.86KiB 10.56KiB 0 0.037972 False False
http_to_http_acks -303.63KiB -1.64 80.71% 18.12MiB 7.88MiB 164.7KiB 0 0.434638 17.83MiB 7.9MiB 165.06KiB 0 0.442855 True True

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Soak Test Results

Baseline: f825421
Comparison: 09c2246
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_datadog_logs 1.27MiB 1.77 100.00% 72.07MiB 3.45MiB 72.12KiB 0 0.0479159 73.34MiB 4.41MiB 92.24KiB 0 0.0601534 False False
datadog_agent_remap_datadog_logs_acks 1.13MiB 1.54 100.00% 73.88MiB 1.29MiB 27.04KiB 0 0.0174896 75.01MiB 4.12MiB 86.02KiB 0 0.0549056 False False
syslog_loki 197.2KiB 1.31 100.00% 14.68MiB 803.18KiB 16.34KiB 0 0.053412 14.87MiB 554.64KiB 11.32KiB 0 0.0364067 False False
socket_to_socket_blackhole 109.04KiB 0.78 100.00% 13.59MiB 593.81KiB 12.1KiB 0 0.0426474 13.7MiB 570.24KiB 11.63KiB 0 0.0406362 False False
http_to_http_acks 102.8KiB 0.57 33.91% 17.77MiB 7.96MiB 166.42KiB 0 0.447749 17.87MiB 7.89MiB 164.97KiB 0 0.441637 True True
datadog_agent_remap_blackhole_acks 405.14KiB 0.55 100.00% 71.96MiB 3.46MiB 72.12KiB 0 0.0480255 72.36MiB 1.78MiB 37.27KiB 0 0.0246485 False False
http_to_http_noack 96.53KiB 0.4 100.00% 23.75MiB 1.06MiB 22.12KiB 0 0.0446552 23.85MiB 241.33KiB 4.93KiB 0 0.00988089 False False
http_pipelines_blackhole 5.35KiB 0.11 24.69% 4.66MiB 561.75KiB 11.51KiB 0 0.117611 4.67MiB 613.27KiB 12.5KiB 0 0.128254 False False
fluent_elasticsearch 54.23KiB 0.07 99.65% 79.42MiB 919.84KiB 18.52KiB 0 0.0113082 79.47MiB 52.96KiB 1.07KiB 0 0.000650634 False False
datadog_agent_remap_blackhole 40.75KiB 0.06 34.27% 68.1MiB 3.12MiB 65.39KiB 0 0.0458333 68.14MiB 3.08MiB 64.52KiB 0 0.045211 False False
splunk_hec_indexer_ack_blackhole 9.51KiB 0.04 34.00% 23.76MiB 772.47KiB 15.72KiB 0 0.0317401 23.77MiB 729.53KiB 14.85KiB 0 0.0299638 False False
splunk_transforms_splunk3 6.24KiB 0.04 7.47% 13.87MiB 2.27MiB 47.32KiB 0 0.163459 13.87MiB 2.23MiB 46.75KiB 0 0.160987 False False
http_to_http_json -885.75B -0 7.18% 23.84MiB 332.05KiB 6.78KiB 0 0.0135961 23.84MiB 332.88KiB 6.79KiB 0 0.0136309 False False
splunk_hec_to_splunk_hec_logs_noack -517.81B -0 4.19% 23.84MiB 332.57KiB 6.81KiB 0 0.0136209 23.84MiB 331.79KiB 6.79KiB 0 0.0135895 False False
http_pipelines_blackhole_acks -1.73KiB -0.04 8.24% 4.46MiB 576.63KiB 11.79KiB 0 0.126311 4.46MiB 578.6KiB 11.82KiB 0 0.126791 False False
splunk_hec_to_splunk_hec_logs_acks -24.7KiB -0.1 73.82% 23.78MiB 715.14KiB 14.56KiB 0 0.0293667 23.75MiB 811.68KiB 16.51KiB 0 0.0333651 False False
syslog_log2metric_splunk_hec_metrics -52.75KiB -0.38 99.98% 13.45MiB 599.99KiB 12.21KiB 0 0.0435581 13.4MiB 356.58KiB 7.27KiB 0 0.0259862 False False
http_pipelines_no_grok_blackhole -104.09KiB -0.51 99.12% 19.83MiB 1.3MiB 27.22KiB 0 0.0655745 19.73MiB 1.38MiB 28.89KiB 0 0.0701644 False False
splunk_hec_route_s3 -134.92KiB -0.66 97.00% 19.93MiB 2.06MiB 43.15KiB 0 0.103549 19.8MiB 2.14MiB 44.71KiB 0 0.108011 False False
syslog_log2metric_humio_metrics -146.95KiB -1.21 100.00% 11.88MiB 690.73KiB 14.08KiB 0 0.0567779 11.73MiB 561.66KiB 11.5KiB 0 0.0467324 False False
syslog_regex_logs2metric_ddmetrics -198.24KiB -1.47 100.00% 13.16MiB 702.03KiB 14.29KiB 0 0.0521014 12.96MiB 727.72KiB 14.81KiB 0 0.0548151 False False
syslog_splunk_hec_logs -328.69KiB -1.77 100.00% 18.17MiB 379.12KiB 7.74KiB 0 0.0203689 17.85MiB 350.44KiB 7.17KiB 0 0.0191662 False False
syslog_humio_logs -342.13KiB -1.84 100.00% 18.16MiB 404.88KiB 8.3KiB 0 0.0217735 17.82MiB 400.33KiB 8.2KiB 0 0.0219327 False False

@hencrice
Copy link
Contributor Author

hencrice commented Jun 1, 2022

@jszwedko @fuchsnj I've addressed the remaining comments. Please review.
Also a question, once this is merged, do you guys know when it will be released?

@jszwedko jszwedko enabled auto-merge (squash) June 1, 2022 20:23
@jszwedko
Copy link
Member

jszwedko commented Jun 1, 2022

Looks good, thanks @hencrice ! Once this is merged, it will be in the following nightly release of Vector. It will also be included in the next minor release (0.23) which is currently scheduled for July 5th.

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Soak Test Results

Baseline: 13ecdbd
Comparison: 48c4fda
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
http_to_http_acks 559.17KiB 3.1 98.50% 17.62MiB 7.77MiB 162.43KiB 0 0.440788 18.17MiB 7.77MiB 162.46KiB 0 0.427691 True True
datadog_agent_remap_datadog_logs_acks 2.16MiB 2.91 100.00% 74.13MiB 1.22MiB 25.44KiB 0 0.0164076 76.29MiB 2.96MiB 61.89KiB 0 0.0387449 False False
datadog_agent_remap_datadog_logs 2.05MiB 2.84 100.00% 71.99MiB 2.58MiB 53.89KiB 0 0.035829 74.04MiB 3.86MiB 80.62KiB 0 0.0520632 False False
datadog_agent_remap_blackhole 818.48KiB 1.13 100.00% 70.52MiB 1.43MiB 29.92KiB 0 0.0202582 71.32MiB 884.24KiB 18.09KiB 0 0.0121047 False False
datadog_agent_remap_blackhole_acks 794.78KiB 1.11 100.00% 70.23MiB 2.68MiB 55.96KiB 0 0.0381556 71.01MiB 2.26MiB 47.23KiB 0 0.0318382 False False
socket_to_socket_blackhole 150.85KiB 1.06 100.00% 13.94MiB 500.69KiB 10.2KiB 0 0.0350739 14.09MiB 493.18KiB 10.05KiB 0 0.0341864 False False
http_pipelines_blackhole_acks 39.5KiB 0.84 98.78% 4.6MiB 546.23KiB 11.18KiB 0 0.115813 4.64MiB 543.21KiB 11.1KiB 0 0.114216 False False
http_pipelines_blackhole 24.08KiB 0.51 84.59% 4.65MiB 566.83KiB 11.61KiB 0 0.118913 4.68MiB 601.75KiB 12.27KiB 0 0.125604 False False
http_to_http_noack 95.57KiB 0.39 100.00% 23.75MiB 1.05MiB 21.82KiB 0 0.0440314 23.85MiB 241.11KiB 4.92KiB 0 0.00987227 False False
splunk_hec_route_s3 52.35KiB 0.26 56.14% 19.35MiB 2.26MiB 47.15KiB 0 0.116562 19.4MiB 2.32MiB 48.4KiB 0 0.119327 False False
syslog_loki 34.15KiB 0.22 99.96% 14.88MiB 414.68KiB 8.45KiB 0 0.0272017 14.92MiB 226.99KiB 4.64KiB 0 0.0148565 False False
fluent_elasticsearch 16.88KiB 0.02 92.32% 79.46MiB 471.26KiB 9.48KiB 0 0.00579088 79.47MiB 52.74KiB 1.06KiB 0 0.000647961 False False
http_to_http_json 3.69KiB 0.02 27.66% 23.84MiB 374.92KiB 7.65KiB 0 0.0153555 23.84MiB 346.01KiB 7.06KiB 0 0.0141691 False False
splunk_hec_to_splunk_hec_logs_acks -581.72B -0 2.04% 23.76MiB 773.15KiB 15.73KiB 0 0.0317673 23.76MiB 774.14KiB 15.75KiB 0 0.0318088 False False
http_pipelines_no_grok_blackhole 211.38B 0 0.34% 19.27MiB 1.59MiB 33.23KiB 0 0.0824127 19.27MiB 1.7MiB 35.49KiB 0 0.0882717 False False
splunk_hec_to_splunk_hec_logs_noack 556.39B 0 4.51% 23.84MiB 332.57KiB 6.8KiB 0 0.0136215 23.84MiB 331.32KiB 6.78KiB 0 0.01357 False False
syslog_regex_logs2metric_ddmetrics -3.91KiB -0.03 13.74% 12.69MiB 767.32KiB 15.63KiB 0 0.0590301 12.69MiB 801.59KiB 16.31KiB 0 0.0616849 False False
splunk_hec_indexer_ack_blackhole -15.15KiB -0.06 51.40% 23.77MiB 726.71KiB 14.79KiB 0 0.0298453 23.76MiB 783.58KiB 15.94KiB 0 0.0322008 False False
splunk_transforms_splunk3 -28.71KiB -0.21 33.09% 13.21MiB 2.28MiB 47.61KiB 0 0.172613 13.19MiB 2.26MiB 47.39KiB 0 0.171609 False False
syslog_log2metric_humio_metrics -26.33KiB -0.21 99.45% 12.11MiB 430.67KiB 8.78KiB 0 0.0347278 12.08MiB 175.61KiB 3.6KiB 0 0.0141906 False False
syslog_log2metric_splunk_hec_metrics -125.05KiB -0.92 100.00% 13.31MiB 684.86KiB 13.93KiB 0 0.0502537 13.18MiB 566.19KiB 11.54KiB 0 0.0419306 False False
syslog_humio_logs -242.89KiB -1.32 100.00% 17.91MiB 158.42KiB 3.25KiB 0 0.00863613 17.67MiB 153.57KiB 3.14KiB 0 0.00848431 False False
syslog_splunk_hec_logs -318.79KiB -1.7 100.00% 18.34MiB 138.59KiB 2.83KiB 0 0.00737693 18.03MiB 126.59KiB 2.59KiB 0 0.00685454 False False

@jszwedko jszwedko merged commit 5b0f473 into vectordotdev:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws_cloudwatch_logs to support json/emf

4 participants