Skip to content

APM aggregation trace metrics don't take span "kind" into account #24273

@thenayr

Description

@thenayr

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

When forwarding traces from datadog agent -> vector -> datadog, the APM aggregation metrics lose the "kind" bucket which then defaults to span.kind = "internal" within Datadog.

This makes the APM page for a particular service within datadog appear to break or change because APM metrics that were being tagged as server are suddenly coming in a internal.

Relevant code here - https://github.com/DataDog/datadog-agent/blob/b1be6ec83e7b5efcab72eb9b684d50ed76c53a71/pkg/trace/stats/aggregation.go#L103

Missing the span kind in the Vector aggregation key - https://github.com/vectordotdev/vector/blob/master/src/sinks/datadog/traces/apm_stats/aggregation.rs#L27

Configuration


Version

0.46.0

Debug Output


Example Data

No response

Additional Context

No response

References

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: bugA code related bug.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions