Skip to content

Conversation

weissi
Copy link
Contributor

@weissi weissi commented May 29, 2024

Some nightly Swift compilers complain that DiscardingTaskGroup doesn't conform to TaskGroupProtocol. This patch works around it.

@gwynne
Copy link
Member

gwynne commented May 29, 2024

@weissi It seems according to the CI that this not only breaks 5.8+, it doesn't actually solve the error (despite the delightfully ironic "candidate exactly matches" message in the error spew 😆)

@weissi weissi force-pushed the jw-workaround-beta branch from ebcd7a1 to 4740345 Compare May 29, 2024 14:37
@weissi
Copy link
Contributor Author

weissi commented May 29, 2024

@weissi It seems according to the CI that this not only breaks 5.8+, it doesn't actually solve the error (despite the delightfully ironic "candidate exactly matches" message in the error spew 😆)

argh, seems to depend on the compiler & SDK version :P.

@weissi
Copy link
Contributor Author

weissi commented May 29, 2024

@gwynne better now

@fabianfett fabianfett merged commit d379584 into vapor:main May 29, 2024
@fabianfett fabianfett added the semver-patch No public API change. label May 29, 2024
@weissi weissi deleted the jw-workaround-beta branch May 29, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch No public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants