Skip to content

Conversation

vkill
Copy link
Contributor

@vkill vkill commented Jun 17, 2019

Hi, @tanner0101 , please review it. thanks.

@tanner0101 tanner0101 added the enhancement New feature or request label Jun 19, 2019
Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new methods on PostgresData look great, thank you! Just one concern regarding the naming of the protocol.

Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@tanner0101 tanner0101 merged commit aa528ef into vapor:master Jun 24, 2019
@penny-coin
Copy link

Hey @vkill, you just merged a pull request, have a coin!

You now have 5 coins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants