Finally remove @retroactive @unchecked Sendable from crypto types
#232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
- Coverage 83.79% 83.52% -0.27%
==========================================
Files 56 56
Lines 1493 1493
==========================================
- Hits 1251 1247 -4
- Misses 242 246 +4
🚀 New features to boost your workflow:
|
MahdiBM
reviewed
Oct 11, 2025
| extension P384.Signing.ECDSASignature: ECDSASignature, @unchecked @retroactive Sendable {} | ||
| extension P384.Signing.PublicKey: @unchecked @retroactive Sendable {} | ||
| extension P384: @unchecked @retroactive Sendable {} | ||
| extension P384.Signing.PrivateKey: ECDSAPrivateKey {} |
There was a problem hiding this comment.
We should require a version high enough for these Sendable coformances to be always available.
There was a problem hiding this comment.
Yep just waiting on Certificates to have a Crypto 4 release and then will bump both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.