Skip to content

Conversation

sviderock
Copy link
Contributor

Description

Add intellisense to translations by following the official i18next guide:

  • Add i18next.d.ts file
  • Add "resolveJsonModule": true to tsconfig.json
  • Add "resolveJsonModule": false to tsconfig.test.json as setting this config to true conflicts with the existing "moduleResolution": "Classic" and fails all the tests with the following error:
error TS5070: Option '--resolveJsonModule' cannot be specified when 'moduleResolution' is set to 'classic'.

Test plan

Screenshot 2024-09-11 at 18 25 25
Screenshot 2024-09-11 at 18 25 39

Related issues

N/A

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

@sviderock sviderock requested review from kathaypacific and removed request for kathaypacific September 11, 2024 15:50
@sviderock sviderock marked this pull request as draft September 12, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant