Optimize NextKey / NextPosition in TermIterator with priority-queue for min key/position checks #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karthik Subbarao <[email protected]>
Signed-off-by: Karthik Subbarao <[email protected]>
Signed-off-by: Karthik Subbarao <[email protected]>
Signed-off-by: Karthik Subbarao <[email protected]>
Signed-off-by: Karthik Subbarao <[email protected]>
yairgott
reviewed
Dec 2, 2025
| key_iterators_(std::move(key_iterators)), | ||
| pos_iterators_(), | ||
| current_key_(), | ||
| current_position_(std::nullopt), |
Collaborator
There was a problem hiding this comment.
nit: No need to initialize with std::nullopt, it's the default value.
Comment on lines
+21
to
+25
| untracked_keys_(untracked_keys), | ||
| key_heap_(), | ||
| pos_heap_(), | ||
| current_key_indices_(), | ||
| current_pos_indices_() { |
Collaborator
There was a problem hiding this comment.
nit: no need to explicitly call the default constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not review yet - I am working on this PR when I get time in between some other core changes, and waiting for the core changes to first get merged into the fulltext branch. After that, I will have this branch updated on latest changes and mark it as ready for review.
In this PR, I optimize NextKey / NextPosition in TermIterator by using a priority queue for efficiently finding the min key and min position when using the key iterator and position iterator