Skip to content

Update arguments for ft.create and ft.search json (#369) #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eric-musliner wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update arguments for ft.create and ft.search json (#369) #504

eric-musliner wants to merge 2 commits into from

Conversation

@eric-musliner
Copy link

@eric-musliner eric-musliner commented Nov 26, 2025

  • Command arguments for ft.create and ft.search were incomplete and blocking addition of ValkeySearch to the valkey-swift client

@eric-musliner
Update arguments for ft.create and ft.search json (valkey-io#369)
7d092fa 
 - Command arguments for ft.create and ft.search were incomplete and
   blocking addition of ValkeySearch to the valkey-swift client

Signed-off-by: Eric Musliner <[email protected]>
@eric-musliner eric-musliner mentioned this pull request Nov 26, 2025
Open
@eric-musliner
Copy link
Author

eric-musliner commented Dec 9, 2025

Hi, this could definitely use a second set of eyes to make sure I'm not missing anything. It's currently blocking the inclusion of the ValkeySearch commands in valkey-swift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eric-musliner @allenss-amazon