Fix AOF rewrite and restore BF tests #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackcam
reviewed
Oct 14, 2025
Member
|
@arpitbbhayani can you fix the DCO? |
arpitbbhayani
force-pushed
the
1.0
branch
2 times, most recently
from
07d7fef to
07488e2
Compare
The AOF rewrite tests were failing because bloom filter data was not being properly restored after server restart. The root cause was twofold: Root Cause: Tests were not properly configuring AOF persistence for server restart Changes: - Updated AOF tests to enable appendonly before adding data - Added wait for initial AOF rewrite to prevent concurrent rewrites - Set appendonly in server startup args for proper AOF loading on restart Also includes minor fixes: - Changed build.sh shebang to bash for better compatibility - Updated pytest requirement to 7.4.3 - Fixed indentation in utils.rs documentation Fixes valkey-io#74 Signed-off-by: Arpit Bhayani <[email protected]>
Author
|
Thank you so much for reviewing the code. Apologies that it took some time for me to come back. Now, the PR only fixes the AOF tests that were failing and other changes have been reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AOF rewrite tests were failing because bloom filter data was not being properly restored after server restart. The root cause was twofold:
Changes:
Also includes minor fixes:
Fixes #74