feat(cardano): Message signing

.github/actions/environment/action.yml

@@ -9,12 +9,12 @@ runs:
   using: "composite"
   steps:
     - name: Install nix
-      uses: cachix/install-nix-action@v23
+      uses: cachix/install-nix-action@v31
       with:
         nix_path: nixpkgs=channel:nixos-unstable
     - name: Dependencies nixpkgs
       run: timeout -v --kill-after=10 500 nix-shell --arg fullDeps "${{ inputs.full-deps }}" --run "true"
       shell: sh
     - name: Dependencies poetry
-      run: timeout -v --kill-after=10 100 nix-shell --arg fullDeps "${{ inputs.full-deps }}" --run "poetry install"
+      run: timeout -v --kill-after=10 200 nix-shell --arg fullDeps "${{ inputs.full-deps }}" --run "poetry install"
       shell: sh

.github/workflows/core.yml

@@ -206,7 +206,7 @@ jobs:
           submodules: recursive
       - uses: ./.github/actions/environment
       - run: nix-shell --run "poetry run make -C core build_unix"
-      - run: nix-shell --arg fullDeps true --run "cd vendor/ts-tvl/tvl/server/model_config && poetry env use 3.12 && poetry install && poetry run model_server tcp -c model_config.yml &"
+      - run: nix-shell --arg fullDeps true --run "cd vendor/ts-tvl/model_configs/example_config && poetry env use 3.12 && poetry install && poetry run model_server tcp -c example_config.yml &"
       - run: nix-shell --run "poetry run make -C core test"
       - run: nix-shell --run "poetry run make -C core test_emu_sanity"  # sanity check non-frozen emulator
 
@@ -527,35 +527,6 @@ jobs:
       - uses: ./.github/actions/environment
       - run: nix-shell --run "poetry run core/tools/size/checker.py core/build/firmware/firmware.elf"
 
-  # Compares the current flash space with the situation in the current master
-  # Fails if the new binary is significantly larger than the master one
-  # (the threshold is defined in the script, currently 5kb).
-  # Also generates a report with the current situation
-  core_flash_size_compare:
-    name: Flash size comparison
-    runs-on: ubuntu-latest
-    needs: core_firmware
-    strategy:
-      fail-fast: false
-      matrix:
-        model: [T2T1]  # FIXME: T2T1 url is hardcoded in compare_master.py
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          submodules: recursive
-          fetch-depth: 0
-      - uses: actions/download-artifact@v4
-        with:
-          name: core-firmware-${{ matrix.model }}-universal-normal
-          path: core/build
-      - uses: ./.github/actions/environment
-      - run: nix-shell --run "poetry run core/tools/size/compare_master.py core/build/firmware/firmware.elf -r firmware_elf_size_report.txt"
-      - uses: actions/upload-artifact@v4
-        with:
-          name: core-test-flash-size-${{ matrix.model }}
-          path: firmware_elf_size_report.txt
-          retention-days: 7
-
   # Monero tests.
   core_monero_test:
     name: Monero test (${{ matrix.model }}, ${{ matrix.asan }})

.gitmodules

@@ -33,6 +33,7 @@
 [submodule "vendor/libtropic"]
 	path = vendor/libtropic
 	url = https://github.com/tropicsquare/libtropic.git
+	branch = develop
 [submodule "vendor/ts-tvl"]
 	path = vendor/ts-tvl
 	url = https://github.com/tropicsquare/ts-tvl

common/protob/messages-cardano.proto

@@ -6,6 +6,7 @@ option java_package = "com.satoshilabs.trezor.lib.protobuf";
 option java_outer_classname = "TrezorMessageCardano";
 
 import "messages-common.proto";
+import "options.proto";
 
 enum CardanoDerivationType {
     LEDGER = 0;
@@ -237,6 +238,7 @@ message CardanoSignTxInit {
     optional uint32 reference_inputs_count = 21 [default=0];
     optional bool chunkify = 22;                                // display the address in chunks of 4 characters
     optional bool tag_cbor_sets = 23 [default=false];           // use tag 258 for sets in cbor
+    optional common.PaymentRequest payment_req = 24 [(experimental_field)=true]; // SLIP-24 payment request
 }
 
 /**
@@ -524,3 +526,48 @@ message CardanoTxBodyHash {
  */
 message CardanoSignTxFinished {
 }
+
+/**
+ * Request: Ask device to sign a message containing arbitrary data
+ * @start
+ * @next CardanoMessageDataRequest
+ * @next CardanoMessageSignature
+ */
+message CardanoSignMessageInit {
+    optional uint32 protocol_magic = 1;                           // network's protocol magic
+    optional uint32 network_id = 2;                               // network id - mainnet or testnet
+    repeated uint32 signing_path = 3;                             // BIP-32-style path to derive the signing key from master node
+    required uint32 payload_size = 4;                             // size of the payload to be signed
+    required bool prefer_hex_display = 5;                         // whether to decode payload as hex even if valid ascii
+    optional CardanoAddressParametersType address_parameters = 6;
+    required CardanoDerivationType derivation_type = 7;
+}
+
+/**
+ * Device requests data chunk with specific size and offset
+ * @next CardanoMessageDataResponse
+ */
+message CardanoMessageDataRequest {
+    required uint32 length = 1;        // size of data chunk to read
+    required uint32 offset = 2;        // offset from start of payload
+}
+
+/**
+ * Client provides requested data chunk
+ * @next CardanoMessageDataRequest
+ * @next CardanoMessageSignature
+ */
+message CardanoMessageDataResponse {
+    required bytes data = 1;  // the requested data chunk
+}
+
+
+/**
+ * Response: Contains signature for message and address used in signed headers
+ * @end
+ */
+message CardanoMessageSignature {
+    required bytes signature = 1; // signature for structure containing payload and protected headers
+    required bytes address = 2;   // value of the address field in protected headers
+    required bytes pub_key = 3;   // public key given by signing path
+}

common/protob/messages-solana.proto

@@ -1,6 +1,9 @@
 syntax = "proto2";
 package hw.trezor.messages.solana;
 
+import "messages-common.proto";
+import "options.proto";
+
 /**
  * Request: Ask device for public key corresponding to address_n path
  * @start
@@ -69,6 +72,7 @@ message SolanaSignTx {
     repeated uint32 address_n = 1;      // BIP-32 path to derive the key to sign with
     required bytes serialized_tx = 2;   // serialized tx to be signed
     optional SolanaTxAdditionalInfo additional_info = 3;
+    optional common.PaymentRequest payment_req = 4 [(experimental_field)=true]; // SLIP-24 payment request
 }
 
 /**

common/protob/messages-thp.proto

@@ -98,7 +98,8 @@ message ThpCreateNewSession {
  * @next ThpPairingRequestApproved
  */
 message ThpPairingRequest {
-    optional string host_name = 1;     // Human-readable host name
+    optional string host_name = 1;     // Human-readable host name (browser name for web apps)
+    optional string app_name = 2;      // Human-readable application name
 }
 
 /**
@@ -245,8 +246,9 @@ message ThpEndResponse {}
  */
  message ThpCredentialMetadata {
     option (internal_only) = true;
-    optional string host_name = 1;     // Human-readable host name
+    optional string host_name = 1;     // Human-readable host name (browser name for web apps)
     optional bool autoconnect = 2;     // Whether host is allowed to autoconnect without user confirmation
+    optional string app_name = 3;      // Human-readable application name
 }
 
 /**

common/protob/messages.proto

@@ -250,6 +250,10 @@ enum MessageType {
     MessageType_CardanoTxInlineDatumChunk = 335 [(wire_in) = true];
     MessageType_CardanoTxReferenceScriptChunk = 336 [(wire_in) = true];
     MessageType_CardanoTxReferenceInput = 337 [(wire_in) = true];
+    MessageType_CardanoSignMessageInit = 338 [(wire_in) = true];
+    MessageType_CardanoMessageDataRequest = 339 [(wire_out) = true];
+    MessageType_CardanoMessageDataResponse = 340 [(wire_in) = true];
+    MessageType_CardanoMessageSignature = 341 [(wire_out) = true];
 
     // Ripple
     MessageType_RippleGetAddress = 400 [(wire_in) = true];

common/tests/fixtures/cardano/sign_message.failed.json

@@ -0,0 +1,37 @@
+{
+  "setup": {
+    "mnemonic": "all all all all all all all all all all all all",
+    "passphrase": ""
+  },
+  "tests": [
+    {
+      "description": "Missing network id and protocol magic",
+      "parameters": {
+        "signing_path": "m/1852'/1815'/4'/0/0",
+        "address_parameters": {
+          "addressType": 0,
+          "path": "m/1852'/1815'/0'/0/0",
+          "stakingPath": "m/1852'/1815'/0'/2/0"
+        },
+        "payload": "",
+        "prefer_hex_display": true
+      },
+      "result": {
+        "error_message": "Must specify network_id and protocol_magic if using address_parameters"
+      }
+    },
+    {
+      "description": "Reject probable hash 28-byte non-ASCII payload",
+      "parameters": {
+        "signing_path": "m/1852'/1815'/4'/0/0",
+        "network_id": 1,
+        "protocol_magic": 764824073,
+        "payload": "ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00",
+        "prefer_hex_display": true
+      },
+      "result": {
+        "error_message": "The payload is interpreted as a hash and cannot be signed"
+      }
+    }
+  ]
+}

common/tests/fixtures/cardano/sign_message.json

@@ -0,0 +1,125 @@
+{
+  "setup": {
+    "mnemonic": "all all all all all all all all all all all all",
+    "passphrase": ""
+  },
+  "tests": [
+    {
+      "description": "Sign short non-ASCII payload",
+      "parameters": {
+        "signing_path": "m/1852'/1815'/4'/0/0",
+        "payload": "ff00",
+        "prefer_hex_display": true
+      },
+      "result": {
+        "signature": "5ad6ba670e65353b2c1ad4053a1ed4a9348a73fe965ffa0afafa24bad06e3eb3e325d49029604c09bf665c3c43a750ec81a43b1f8b746b07e999b913b980d006",
+        "address": "d9553a4de9c7ad8532abdb1d0a7f425b8007d25c9f1edcf0b5f5c3ba",
+        "pub_key": "67e3d14e1e0db2a6ff68832994451f63d3e92a4ee85c3681d72634ccfe889f2c"
+      }
+    },
+    {
+      "description": "Sign short non-ASCII payload with address parameters",
+      "parameters": {
+        "signing_path": "m/1852'/1815'/4'/0/0",
+        "network_id": 1,
+        "protocol_magic": 764824073,
+        "payload": "ff00",
+        "address_parameters": {
+          "addressType": 0,
+          "path": "m/1852'/1815'/0'/0/0",
+          "stakingPath": "m/1852'/1815'/0'/2/0"
+        },
+        "prefer_hex_display": true
+      },
+      "result": {
+        "signature": "9efaff0b74c0beb2cadd727d8bafe13b31107235c5fc46c6c33e596e024d391c9fbe37072e43965add6ee0a4788562382031486b74fd59d636aa1ca3b1ddfe06",
+        "address": "0180f9e2c88e6c817008f3a812ed889b4a4da8e0bd103f86e7335422aa122a946b9ad3d2ddf029d3a828f0468aece76895f15c9efbd69b4277",
+        "pub_key": "67e3d14e1e0db2a6ff68832994451f63d3e92a4ee85c3681d72634ccfe889f2c"
+      }
+    },
+    {
+      "description": "Sign short ASCII payload",
+      "parameters": {
+        "signing_path": "m/1852'/1815'/4'/0/0",
+        "payload": "54657374",
+        "prefer_hex_display": false
+      },
+      "result": {
+        "signature": "2201b8e7fa9ea919935e06ecc3e845433855066acaaf61cb8e624a2eb7139b73a9d126e7ee04548fff06ac933bd5419fc78c5aebee9b536cbee1481b52ec3e03",
+        "address": "d9553a4de9c7ad8532abdb1d0a7f425b8007d25c9f1edcf0b5f5c3ba",
+        "pub_key": "67e3d14e1e0db2a6ff68832994451f63d3e92a4ee85c3681d72634ccfe889f2c"
+      }
+    },
+    {
+      "description": "Sign short ASCII payload rendered as hex",
+      "parameters": {
+        "signing_path": "m/1852'/1815'/4'/0/0",
+        "payload": "54657374",
+        "prefer_hex_display": true
+      },
+      "result": {
+        "signature": "2201b8e7fa9ea919935e06ecc3e845433855066acaaf61cb8e624a2eb7139b73a9d126e7ee04548fff06ac933bd5419fc78c5aebee9b536cbee1481b52ec3e03",
+        "address": "d9553a4de9c7ad8532abdb1d0a7f425b8007d25c9f1edcf0b5f5c3ba",
+        "pub_key": "67e3d14e1e0db2a6ff68832994451f63d3e92a4ee85c3681d72634ccfe889f2c"
+      }
+    },
+    {
+      "description": "Sign empty payload",
+      "parameters": {
+        "signing_path": "m/1852'/1815'/4'/0/0",
+        "payload": "",
+        "prefer_hex_display": true
+      },
+      "result": {
+        "signature": "b09177a06cb2deba7ada89fec96fc4380e746f67c6b16a9ef9ae6b7cbbe941fdad8a8a573b809cd88db296b91b476c436033a29d86a63959e270047e47cd5d0d",
+        "address": "d9553a4de9c7ad8532abdb1d0a7f425b8007d25c9f1edcf0b5f5c3ba",
+        "pub_key": "67e3d14e1e0db2a6ff68832994451f63d3e92a4ee85c3681d72634ccfe889f2c"
+      }
+    },
+    {
+      "description": "Non-ASCII payload falls back to hex",
+      "parameters": {
+        "signing_path": "m/1852'/1815'/4'/0/0",
+        "network_id": 1,
+        "protocol_magic": 764824073,
+        "payload": "ff",
+        "prefer_hex_display": false
+      },
+      "result": {
+        "signature": "eb7e48bb2de912b24ea4e295cfbf338e95e2a2d9c5eb41d72ddd8ebf96ca6128696e91e65e20a755821781b8ea0b4aa7ffcfa6ab0c7da2c67ecaf33fcd596509",
+        "address": "d9553a4de9c7ad8532abdb1d0a7f425b8007d25c9f1edcf0b5f5c3ba",
+        "pub_key": "67e3d14e1e0db2a6ff68832994451f63d3e92a4ee85c3681d72634ccfe889f2c"
+      }
+    },
+    {
+      "description": "Ambiguous ASCII payload falls back to hex",
+      "parameters": {
+        "signing_path": "m/1852'/1815'/4'/0/0",
+        "network_id": 1,
+        "protocol_magic": 764824073,
+        "payload": "20",
+        "prefer_hex_display": false
+      },
+      "result": {
+        "signature": "1cd79c511e58e0d00bc402c24631a982c0f596e13cad38447d4f31213d085b23b9990b45023450f5ab4d47987993af662702b07bfc8195feb80b2c9e1c1dc10f",
+        "address": "d9553a4de9c7ad8532abdb1d0a7f425b8007d25c9f1edcf0b5f5c3ba",
+        "pub_key": "67e3d14e1e0db2a6ff68832994451f63d3e92a4ee85c3681d72634ccfe889f2c"
+      }
+    },
+    {
+      "description": "Long payload",
+      "parameters": {
+        "signing_path": "m/1852'/1815'/4'/0/0",
+        "network_id": 1,
+        "protocol_magic": 764824073,
+        "payload": "aaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff00011100011aaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbddd1bbbdddaafffaaafff000111000111bbbdddaaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff00011100011aaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbdddaaafffaaafff000111000111bbbddd1bbbdddaafffaaafff000111000111bbbdddee",
+        "prefer_hex_display": true
+      },
+      "result": {
+        "signature": "6d1e9bf2f704413b1a99340bb88f27a4a74f00fe7ed891b814a9a0167b6482b0b92982a5eb0be513fe5e432c4a79550d615222cf9ffcf70f42f8e600bf302c0f",
+        "address": "d9553a4de9c7ad8532abdb1d0a7f425b8007d25c9f1edcf0b5f5c3ba",
+        "pub_key": "67e3d14e1e0db2a6ff68832994451f63d3e92a4ee85c3681d72634ccfe889f2c"
+      }
+    }
+  ]
+}