Update Egypt holidays

[KJhellico]

Proposed change

Update Egypt holidays:

• update holidays list and names according to official sources
• add fr locale
• update tests

Type of change

• New country/market holidays support (thank you!)
• Supported country/market holidays update (calendar discrepancy fix, localization)
• Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
• Dependency update (version deprecation/pin/upgrade)
• Bugfix (non-breaking change which fixes an issue)
• Breaking change (a code change causing existing functionality to break)
• New feature (new holidays functionality in general)

Checklist

• I've read and followed the contributing guidelines.
• I've run make check locally; all checks and tests passed.

[coderabbitai]

Summary by CodeRabbit

• New Features

  • Added French language support for Egyptian holidays.
  • Introduced government and school holiday categories for Egypt, with expanded holiday coverage.

• Bug Fixes

  • Corrected and refined holiday names, dates, and observance rules for Egypt.

• Documentation

  • Updated the "Available Countries" table to reflect new languages and holiday categories for Egypt.

• Tests

  • Significantly expanded and modernized test coverage for Egypt, including localization in Arabic, English, and French.

• Style

  • Improved localization and naming consistency across all supported languages for Egyptian holidays.

Walkthrough

This update refactors the Egypt holiday logic to use observed and static holiday bases, introduces custom Islamic and static holiday classes, expands and revises holiday rules, updates localizations for Arabic, English, and adds French, and significantly enhances and restructures the Egypt holiday test suite.

Changes

Files/Paths	Change Summary
README.md	Updated Egypt's supported languages and holiday categories in the available countries table.
holidays/countries/egypt.py	Refactored Egypt holiday class: new inheritance, observed/static holiday support, custom rules, modularized holiday definitions, new classes for Islamic and static holidays, expanded/renamed holidays, and new category methods.
holidays/locale/ar_EG/LC_MESSAGES/EG.po	Updated Arabic (Egypt) translations: refined holiday names, added/removed holidays, changed language code, improved annotations.
holidays/locale/en_US/LC_MESSAGES/EG.po	Updated English (US) translations for Egypt: revised holiday names, added/removed holidays, changed source language, improved formatting.
holidays/locale/fr/LC_MESSAGES/EG.po	Added new French localization file for Egyptian holidays.
tests/countries/test_egypt.py	Major test overhaul: expanded coverage, new and updated tests for holidays, observed rules, categories, and localizations.

Estimated code review effort

4 (~90 minutes)

Possibly related PRs

• Fix missing StaticHolidays in some countries #2729: Both PRs modify country holiday classes to include StaticHolidays in their inheritance and initialization, directly relating to static holiday integration.

Suggested labels

l10n, test

Suggested reviewers

• PPsyrius

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (221c501) to head (0dff6e7).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2742   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          271       271           
  Lines        16160     16199   +39     
  Branches      2182      2190    +8     
=========================================
+ Hits         16160     16199   +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[arkid15r]

LGTM