Archive more links #2622

kritibirda26 · 2025-06-11T20:42:55Z

Proposed change

Replaced some more links with archived versions.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've followed the contributing guidelines
I've successfully run make check, all checks and tests are green

coderabbitai · 2025-06-11T20:43:03Z

Summary by CodeRabbit

Documentation
- Updated reference links in holiday documentation to use archived versions for improved stability and long-term accessibility. No changes to app functionality.

Walkthrough

The docstrings in the Palau and Turks and Caicos Islands holiday modules were updated to replace direct Facebook reference links with archived Wayback Machine URLs. No executable code or logic was changed.

Changes

Files	Change Summary
holidays/countries/palau.py	Updated docstring reference URLs to archived Wayback Machine links.
holidays/countries/turks_and_caicos_islands.py	Updated docstring reference URLs to archived Wayback Machine links.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c94efcd and 7ea9a11.

📒 Files selected for processing (2)

holidays/countries/palau.py (1 hunks)
holidays/countries/turks_and_caicos_islands.py (1 hunks)

🧰 Additional context used

🪛 Pylint (3.3.7)

holidays/countries/palau.py

[convention] 112-112: Line too long (129/100)

(C0301)

[convention] 113-113: Line too long (130/100)

(C0301)

[convention] 114-114: Line too long (130/100)

(C0301)

holidays/countries/turks_and_caicos_islands.py

[convention] 32-32: Line too long (136/100)

(C0301)

[convention] 33-33: Line too long (140/100)

(C0301)

[convention] 34-34: Line too long (136/100)

(C0301)

[convention] 35-35: Line too long (151/100)

(C0301)

[convention] 36-36: Line too long (108/100)

(C0301)

[convention] 37-37: Line too long (108/100)

(C0301)

[convention] 38-38: Line too long (135/100)

(C0301)

⏰ Context from checks skipped due to timeout of 300000ms (3)

GitHub Check: Test build on windows-latest
GitHub Check: Test build on macos-latest
GitHub Check: Test build on ubuntu-latest

🔇 Additional comments (4)

holidays/countries/palau.py (1)

112-114: Updated docstring to use archived Wayback Machine URLs.

Replaced direct Facebook references with stable snapshots to prevent link rot.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 112-112: Line too long (129/100)

(C0301)

[convention] 113-113: Line too long (130/100)

(C0301)

[convention] 114-114: Line too long (130/100)

(C0301)

holidays/countries/turks_and_caicos_islands.py (3)

32-32: Updated 2017 link to archived Wayback Machine URL.

Ensures the docstring points to a persistent snapshot.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 32-32: Line too long (136/100)

(C0301)

34-35: Replaced 2019 and 2020 URLs with archived Wayback Machine snapshots.

Keeps documentation references stable and avoids broken links.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 34-34: Line too long (136/100)

(C0301)

[convention] 35-35: Line too long (151/100)

(C0301)

38-38: Swapped 2023 Facebook reference for archived Wayback Machine link.

Aligns with PR goal of using persistent URLs throughout.

🧰 Tools

🪛 Pylint (3.3.7)

[convention] 38-38: Line too long (135/100)

(C0301)

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate Unit Tests

Create PR with Unit Tests
Commit Unit Tests in branch archive-more-links
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2025-06-11T20:43:49Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-06-11T20:44:39Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c94efcd) to head (7ea9a11).
⚠️ Report is 161 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2622   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          230       230           
  Lines        14636     14636           
  Branches      2045      2045           
=========================================
  Hits         14636     14636

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arkid15r

Looks consistent 👍

KJhellico

LGTM!

Archive more links

7ea9a11

kritibirda26 requested review from arkid15r, KJhellico and PPsyrius as code owners June 11, 2025 20:42

arkid15r reviewed Jun 11, 2025

View reviewed changes

arkid15r enabled auto-merge June 11, 2025 21:05

KJhellico approved these changes Jun 11, 2025

View reviewed changes

arkid15r added this pull request to the merge queue Jun 11, 2025

Merged via the queue into vacanza:dev with commit 39aba05 Jun 11, 2025
33 checks passed

arkid15r mentioned this pull request Jun 16, 2025

v0.75 #2639

Merged

coderabbitai bot mentioned this pull request Jun 29, 2025

Archive a link for Turks and Caicos holidays #2688

Merged

9 tasks

arkid15r added the gsoc2025 label Aug 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Archive more links #2622

Archive more links #2622

Uh oh!

kritibirda26 commented Jun 11, 2025

Uh oh!

coderabbitai bot commented Jun 11, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented Jun 11, 2025

Uh oh!

codecov bot commented Jun 11, 2025 •

edited

Loading

Uh oh!

arkid15r left a comment

Uh oh!

KJhellico left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Archive more links #2622

Archive more links #2622

Uh oh!

Conversation

kritibirda26 commented Jun 11, 2025

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented Jun 11, 2025

Quality Gate passed

Uh oh!

codecov bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Jun 11, 2025 •

edited

Loading

codecov bot commented Jun 11, 2025 •

edited

Loading