Update Argentina holidays: add 2018 G20 Leaders' Summit for Buenos Aires #2529

PPsyrius · 2025-05-06T04:07:14Z

Proposed change

Adds November 30, 2018, as a one-off public holiday in Buenos Aires for the G20 Leaders' Summit.

Resolves #2528.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've followed the contributing guidelines
I've successfully run make check, all checks and tests are green

coderabbitai · 2025-05-06T04:07:21Z

Summary by CodeRabbit

New Features
- Added recognition of the G20 Leaders' Summit as a special public holiday in Buenos Aires on November 30, 2018.
Documentation
- Updated documentation to include a reference for the new subdivision-level holiday.
Translations
- Added and updated translations for the G20 Leaders' Summit holiday in English, Spanish, and Ukrainian.
Tests
- Introduced a new test to verify the correct handling of the Buenos Aires G20 holiday.

Walkthrough

A one-time public holiday for the G20 Leaders' Summit on November 30, 2018, in Buenos Aires, Argentina, was added. This includes code, translation, snapshot, and test updates to reflect the new subdivision-level holiday without altering existing logic or other holidays.

Changes

Files/Paths	Change Summary
holidays/countries/argentina.py	Added G20 Leaders' Summit holiday for Buenos Aires in 2018; updated documentation and holiday mapping.
holidays/locale/en_US/LC_MESSAGES/AR.po holidays/locale/es/LC_MESSAGES/AR.po holidays/locale/uk/LC_MESSAGES/AR.po	Added translation entry for G20 Leaders' Summit; updated metadata headers.
snapshots/countries/AR_B.json	Appended 2018-11-30 G20 Leaders' Summit holiday entry.
tests/countries/test_argentina.py	Added a test for the special Buenos Aires subdivision holiday on 2018-11-30.

Assessment against linked issues

Objective	Addressed	Explanation
Add Argentina's one-time public holiday for G20 Summit (2018-11-30) in Buenos Aires (#2528)	✅

Suggested labels

snapshot, test

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5cbd555 and 0648fa5.

📒 Files selected for processing (6)

holidays/countries/argentina.py (3 hunks)
holidays/locale/en_US/LC_MESSAGES/AR.po (2 hunks)
holidays/locale/es/LC_MESSAGES/AR.po (2 hunks)
holidays/locale/uk/LC_MESSAGES/AR.po (2 hunks)
snapshots/countries/AR_B.json (1 hunks)
tests/countries/test_argentina.py (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

tests/countries/test_argentina.py (2)

tests/countries/test_malaysia.py (1)

test_special_subdiv_holidays (115-127)

tests/common.py (1)

assertHoliday (150-152)

⏰ Context from checks skipped due to timeout of 300000ms (1)

GitHub Check: Test build on windows-latest

🔇 Additional comments (15)

holidays/countries/argentina.py (3)

831-832: Nice addition of proper documentation reference!

Good job documenting the source for the G20 Leaders' Summit special holiday with a web archive link for future reference. This will help maintain the historical record for why this holiday was added.

875-876: Well-formatted holiday string constant

The holiday name translation string follows the established pattern in the codebase and properly identifies this as the G20 Leaders' Summit.

995-997: Correct implementation of subdivision-specific holiday

The implementation correctly adds the G20 Leaders' Summit to the Buenos Aires subdivision (B) for the specific date November 30, 2018. The dictionary structure follows the existing pattern used for other special holidays.

snapshots/countries/AR_B.json (1)

1053-1053: Properly added holiday to the Buenos Aires snapshot

The G20 Leaders' Summit has been correctly added to the AR_B.json snapshot file for November 30, 2018. This ensures the holiday data is consistent with the code implementation.

holidays/locale/es/LC_MESSAGES/AR.po (2)

17-27: Metadata updates look good

The PO file metadata has been properly updated with new version numbers and translator information. This maintains the integrity of the translation file.

370-372: Translation entry correctly added

The Spanish translation entry for the G20 Leaders' Summit has been added at the appropriate location in the file, following the same format as other holiday entries.

tests/countries/test_argentina.py (1)

102-104: Implementation looks good for testing the G20 Leaders' Summit holiday.

The test correctly verifies that November 30, 2018, is recognized as a holiday specifically for the Buenos Aires subdivision (code "B"). This aligns perfectly with the PR objective of adding the G20 Leaders' Summit holiday.

holidays/locale/en_US/LC_MESSAGES/AR.po (4)

17-17: Project version update looks good.

Version updated from 0.70 to 0.73, matching the new holiday addition.

19-20: PO revision date and translator info updated appropriately.

The updated metadata reflects the changes being made to the file.

27-27: Poedit generator version updated.

The version upgrade from 3.5 to 3.6 is appropriate.

370-372: Excellent addition of the G20 Leaders' Summit translation.

The Spanish to English translation for the G20 Leaders' Summit holiday is correct and properly formatted, supporting the new holiday for Buenos Aires on November 30, 2018.

holidays/locale/uk/LC_MESSAGES/AR.po (4)

17-17: Project version update looks good.

Version updated from 0.70 to 0.73, matching the new holiday addition.

19-20: PO revision date and translator info updated appropriately.

The updated metadata reflects the changes being made to the file.

27-27: Poedit generator version updated.

The version upgrade from 3.5 to 3.6 is appropriate.

370-372: Ukrainian translation for G20 Leaders' Summit added correctly.

The translation "Саміт лідерів Групи двадцяти (G20)" is appropriate for the G20 Leaders' Summit and maintains consistency with other holiday translations in the file.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2025-05-06T04:08:04Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-05-06T04:09:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5cbd555) to head (0648fa5).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2529   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          215       215           
  Lines        13663     13665    +2     
  Branches      1930      1930           
=========================================
+ Hits         13663     13665    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KJhellico

LGTM!

arkid15r

LGTM 👍

…res (vacanza#2529)

Update Argentina holidays: add 2018 G20 Leaders' Summit for Buenos Aires

0648fa5

PPsyrius requested review from arkid15r and KJhellico as code owners May 6, 2025 04:07

github-actions bot added l10n snapshot test labels May 6, 2025

KJhellico approved these changes May 6, 2025

View reviewed changes

arkid15r reviewed May 6, 2025

View reviewed changes

arkid15r added this pull request to the merge queue May 6, 2025

Merged via the queue into vacanza:dev with commit fb8e6dc May 6, 2025
33 checks passed

PPsyrius deleted the ar_2018_g20 branch May 6, 2025 16:20

kritibirda26 pushed a commit to kritibirda26/holidays that referenced this pull request May 7, 2025

Update Argentina holidays: add 2018 G20 Leaders' Summit for Buenos Ai…

fa27883

…res (vacanza#2529)

KJhellico mentioned this pull request May 19, 2025

v0.73 #2553

Merged

ShalomDee pushed a commit to ShalomDee/holidays that referenced this pull request Jun 2, 2025

Update Argentina holidays: add 2018 G20 Leaders' Summit for Buenos Ai…

db26b69

…res (vacanza#2529)

coderabbitai bot mentioned this pull request Jul 25, 2025

Update Germany holidays: add Augsburg Peace Festival for Augsburg #2750

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update Argentina holidays: add 2018 G20 Leaders' Summit for Buenos Aires #2529

Update Argentina holidays: add 2018 G20 Leaders' Summit for Buenos Aires #2529

Uh oh!

PPsyrius commented May 6, 2025

Uh oh!

coderabbitai bot commented May 6, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented May 6, 2025

Uh oh!

codecov bot commented May 6, 2025 •

edited

Loading

Uh oh!

KJhellico left a comment

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Update Argentina holidays: add 2018 G20 Leaders' Summit for Buenos Aires #2529

Update Argentina holidays: add 2018 G20 Leaders' Summit for Buenos Aires #2529

Uh oh!

Conversation

PPsyrius commented May 6, 2025

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Assessment against linked issues

Suggested labels

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented May 6, 2025

Quality Gate passed

Uh oh!

codecov bot commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented May 6, 2025 •

edited

Loading

codecov bot commented May 6, 2025 •

edited

Loading