Skip to content

refactor!: remove z-index update logic from bringToFront method #9847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

refactor!: remove z-index update logic from bringToFront method #9847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions packages/overlay/src/vaadin-overlay-stack-mixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,18 +81,6 @@ export const OverlayStackMixin = (superClass) =>
* Brings the overlay as visually the frontmost one.
*/
bringToFront() {
// Update z-index to be the highest among all attached overlays
// TODO: Can be removed after switching all overlays to be based on native popover
let zIndex = '';
const frontmost = getAttachedInstances()
.filter((o) => o !== this)
.pop();
if (frontmost) {
const frontmostZIndex = parseFloat(getComputedStyle(frontmost).zIndex);
zIndex = frontmostZIndex + 1;
}
this.style.zIndex = zIndex;

// If the overlay is the last one, or if all other overlays shown above
// are nested overlays (e.g. date-picker inside a dialog), do not call
// `showPopover()` unnecessarily to avoid scroll position being reset.
Expand Down
24 changes: 0 additions & 24 deletions packages/overlay/test/multiple.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,16 +228,6 @@ describe('multiple overlays', () => {
expect(overlay.scrollTop).to.equal(100);
});

it('should grow the z-index by 1', () => {
modeless1.opened = true;
modeless2.opened = true;
modeless1.bringToFront();

const zIndex1 = parseFloat(getComputedStyle(modeless1).zIndex);
const zIndex2 = parseFloat(getComputedStyle(modeless2).zIndex);
expect(zIndex1).to.equal(zIndex2 + 1);
});

it('should bring the newly opened overlay to front', () => {
modeless1.opened = true;
modeless2.opened = true;
Expand All @@ -250,20 +240,6 @@ describe('multiple overlays', () => {
expect(frontmost).to.equal(modeless2);
});

it('should reset z-indexes', () => {
modeless1.opened = true;
modeless2.opened = true;

const zIndex1 = parseFloat(getComputedStyle(modeless1).zIndex);
expect(parseFloat(modeless2.style.zIndex)).to.equal(zIndex1 + 1);

modeless1.opened = false;
modeless2.opened = false;

modeless2.opened = true;
expect(modeless2.style.zIndex).to.be.empty;
});

it('should not call showPopover on bringToFront if only nested overlay is open', () => {
modeless2.opened = true;
modeless2.opened = true;
Expand Down