refactor!: update tooltip overlay to use native popover #9760
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -330,7 +330,6 @@ export const TooltipMixin = (superClass) => | |
| */ | ||
| text: { | ||
| type: String, | ||
| }, | ||
|
|
||
| /** | ||
|
|
@@ -366,26 +365,9 @@ export const TooltipMixin = (superClass) => | |
| type: Boolean, | ||
| sync: true, | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Sets the default focus delay to be used by all tooltip instances, | ||
| * except for those that have focus delay configured using property. | ||
|
|
@@ -420,7 +402,6 @@ export const TooltipMixin = (superClass) => | |
| super(); | ||
|
|
||
| this._uniqueId = `vaadin-tooltip-${generateUniqueId()}`; | ||
|
|
||
| this.__onFocusin = this.__onFocusin.bind(this); | ||
| this.__onFocusout = this.__onFocusout.bind(this); | ||
|
|
@@ -467,19 +448,24 @@ export const TooltipMixin = (superClass) => | |
|
|
||
| this._overlayElement = this.$.overlay; | ||
|
|
||
| this.__contentController = new SlotController(this, 'overlay', 'div', { | ||
| initializer: (element) => { | ||
| element.id = this._uniqueId; | ||
| element.setAttribute('role', 'tooltip'); | ||
| this.__contentNode = element; | ||
| }, | ||
| }); | ||
| this.addController(this.__contentController); | ||
| } | ||
|
|
||
| /** @protected */ | ||
| updated(props) { | ||
| super.updated(props); | ||
|
|
||
| if (props.has('text') || props.has('generator') || props.has('context')) { | ||
| this.__updateContent(); | ||
|
There was a problem hiding this comment. I'm not sure about this method. It mainly exists because of an ugly internal hack which is likely used in some customer project and relies on patching There was a problem hiding this comment. Doesn't really hurt to keep it. |
||
| this.$.overlay.toggleAttribute('hidden', this.__contentNode.textContent.trim() === ''); | ||
| } | ||
| } | ||
|
|
||
| /** @private */ | ||
|
|
@@ -688,18 +674,8 @@ export const TooltipMixin = (superClass) => | |
| } | ||
|
|
||
| /** @private */ | ||
| __updateContent() { | ||
| this.__contentNode.textContent = typeof this.generator === 'function' ? this.generator(this.context) : this.text; | ||
| } | ||
|
|
||
| /** @private */ | ||
|
|
@@ -723,23 +699,4 @@ export const TooltipMixin = (superClass) => | |
| }); | ||
| } | ||
| } | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, tooltip was preserving the text after closing, which is rather unexpected. Tests didn't catch that because the IT assertion returned
nullif novaadin-tooltip-overlaywas found in the document.