fix: do not move focus when focused in on grid via clicking #7323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
web-padawan
approved these changes
Apr 12, 2024
ugur-vaadin
deleted the
fix-do-not-move-focus-when-focused-in-on-grid-via-clicking
branch
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
web-padawan
pushed a commit
that referenced
this pull request
Apr 12, 2024
…7327) Co-authored-by: Ugur Saglam <[email protected]>
ugur-vaadin
added a commit
that referenced
this pull request
Apr 12, 2024
ugur-vaadin
added a commit
that referenced
this pull request
Apr 12, 2024
ugur-vaadin
added a commit
that referenced
this pull request
Apr 12, 2024
This was referenced Apr 12, 2024
web-padawan
pushed a commit
that referenced
this pull request
Apr 15, 2024
web-padawan
pushed a commit
that referenced
this pull request
Apr 15, 2024
web-padawan
pushed a commit
that referenced
this pull request
Apr 15, 2024
|
This ticket/PR has been released with Vaadin 24.4.0.alpha22 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The block in the listener
_onFocusinassumes that if the root target is the top/bottom of the grid, it is the result of a tab/shift-tab action. However, it is also possible that it is the result of a click. In this case, the focus should not be moved.This PR updates the logic to move focus only if it is not caused by a click.
Fixes #2911
Type of change
Checklist