Skip to content

feat: vaadin-virtual-list #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 18, 2021
Merged

feat: vaadin-virtual-list #370

merged 4 commits into from
May 18, 2021

Conversation

@tomivirkki
Copy link
Member

Description

Implements the <vaadin-virtual-list> Web Component

Closes #283

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@tomivirkki tomivirkki added the no-polymer Removing Polymer from Vaadin public APIs label May 11, 2021
@tomivirkki tomivirkki marked this pull request as draft May 11, 2021 09:08
@tomivirkki tomivirkki force-pushed the vaadin-virtual-list branch 3 times, most recently from 34425e5 to ca7960a Compare May 17, 2021 09:54
@tomivirkki tomivirkki marked this pull request as ready for review May 17, 2021 10:16
@tomivirkki tomivirkki force-pushed the vaadin-virtual-list branch from ca7960a to 2ef5338 Compare May 17, 2021 12:23
@tomivirkki tomivirkki requested review from vursen and web-padawan May 17, 2021 12:25
web-padawan
web-padawan reviewed May 17, 2021
View reviewed changes
tomivirkki
tomivirkki commented May 18, 2021
View reviewed changes
packages/vaadin-virtual-list/src/vaadin-virtual-list.js
<style>
:host {
display: block;
height: 200px;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a default value to have <vaadin-virtual-list> with no explicitly defined height to not appear invisible.

web-padawan
web-padawan requested changes May 18, 2021
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki tomivirkki merged commit 978536b into master May 18, 2021
@tomivirkki tomivirkki deleted the vaadin-virtual-list branch May 18, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vursen vursen vursen approved these changes

@web-padawan web-padawan web-padawan approved these changes

Assignees

No one assigned

Labels

no-polymer Removing Polymer from Vaadin public APIs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create virtual-list component

4 participants

@tomivirkki @vursen @web-padawan