fix: issue with grid when grid table body is clicked and enter key is hit #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cell: path[tableIndex - 3] | ||
| rowGroup: tableIndex >= 3 ? path[tableIndex - 1] : null, | ||
| row: tableIndex >= 3 ? path[tableIndex - 2] : null, | ||
| cell: tableIndex >= 3 ? path[tableIndex - 3] : null |
Contributor
There was a problem hiding this comment.
tableIndex >= 3 is repeated 3 times. Could improve this by extracting it into a variable which would also make the code more readable, because the name of the variable indicates why in this case there is no cell/row/rowGroup.
DiegoCardoso
changed the title
…a general _getGridLocation
|
Kudos, SonarCloud Quality Gate passed!
|
sissbruecker
approved these changes
Jun 23, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Jun 23, 2021
… hit (#2146) * fix: it should not throw error when grid table body has focus and enter key is hit * extract comparison into a separate variable * Refactor to merge _parseEventPath and _getGridCellFocusLocation into a general _getGridLocation Co-authored-by: Sascha Ißbrücker <[email protected]>
hdamr
added a commit
that referenced
this pull request
Jun 28, 2021
… hit (#2146) (#2155) * fix: it should not throw error when grid table body has focus and enter key is hit * extract comparison into a separate variable * Refactor to merge _parseEventPath and _getGridCellFocusLocation into a general _getGridLocation Co-authored-by: Sascha Ißbrücker <[email protected]> Co-authored-by: Hadi Amiri <[email protected]> Co-authored-by: Sascha Ißbrücker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue with the grid when the table body of the grid is clicked and enter key is hit, the error shows when no row of the table is selected, Or as in the mentioned in the issue when a row is clicked and empty area of the table is selected and enter key is hit.
Fixes: vaadin/flow-components#1011
Type of change
Checklist