Skip to content

feat: throw when using both a template and a renderer #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2021
Merged

feat: throw when using both a template and a renderer #2098

merged 2 commits into from
Jun 10, 2021

Conversation

@vursen
Copy link
Contributor

@vursen vursen commented Jun 8, 2021 •
edited
Loading

Description

Previously, all the components which had the public support of the Polymer Template API used to throw an exception when using both a template and a renderer. So far as it was a part of the Template API and we no longer support this API, it was decided that the Template Renderer should throw such exceptions instead.

This PR has a purpose to support throwing such exceptions for the Template Renderer.

Type of change

  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen added the no-polymer Removing Polymer from Vaadin public APIs label Jun 8, 2021
@vursen vursen self-assigned this Jun 8, 2021
tomivirkki
tomivirkki reviewed Jun 8, 2021
View reviewed changes
@vursen vursen force-pushed the feat/template-renderer/throw-when-renderer-is-already-provided branch 2 times, most recently from e64532f to 912e984 Compare June 8, 2021 14:07
@vursen vursen requested a review from tomivirkki June 8, 2021 14:17
@vursen vursen force-pushed the feat/template-renderer/throw-when-renderer-is-already-provided branch 2 times, most recently from 7c7a3ab to 70f7742 Compare June 9, 2021 10:47
@vursen vursen force-pushed the feat/template-renderer/throw-when-renderer-is-already-provided branch from 70f7742 to 0be29a9 Compare June 9, 2021 10:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen merged commit 1ab3a80 into master Jun 10, 2021
@vursen vursen deleted the feat/template-renderer/throw-when-renderer-is-already-provided branch June 10, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees

@vursen vursen

Labels

no-polymer Removing Polymer from Vaadin public APIs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vursen @tomivirkki