fix: don't hide rows in the grid logic #2082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
approved these changes
Jun 3, 2021
| import '../vaadin-grid.js'; | ||
| import { getPhysicalItems } from './helpers.js'; | ||
|
|
||
| describe('renderig with lit', () => { |
tomivirkki
force-pushed
the
lit-dynamic-columns
branch
from
df84914 to
666a7b6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from #321
Seems that with very specific timing, it's possible to end up with a grid that has non-empty
itemsbut no visible rows. The bug was reported as part of a Lit project and I couldn't find a way to reproduce it without using Lit in the test as well.The offending line was added a long time ago and doesn't seem to be relevant anymore. Only the virtualizer should be in charge of hiding/unhiding the body row elements.