Skip to content

Conversation

@web-padawan
Copy link
Member

Description

Some SVG icons were missing from the iconset files from because of incorrect regex.
Updated to include align-center, align-left and align-right icons.

Also changed the namespace for vaadin-iconset to use lumo (see #1988)

Depends on #1988 and will be rebase once that PR is merged.

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@web-padawan web-padawan added the no-polymer Removing Polymer from Vaadin public APIs label May 24, 2021
@web-padawan web-padawan requested review from vlukashov and vursen May 24, 2021 17:56
@web-padawan web-padawan marked this pull request as ready for review May 25, 2021 15:30
@web-padawan web-padawan requested a review from vlukashov May 25, 2021 15:30
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@vursen vursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view, all looks good! 👍

@web-padawan web-padawan removed the request for review from vlukashov May 26, 2021 13:22
@web-padawan web-padawan merged commit 3c045ed into master May 26, 2021
@web-padawan web-padawan deleted the fix-lumo-iconset branch May 26, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-polymer Removing Polymer from Vaadin public APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants