refactor: move the array data provider logic to a separate module #1976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
separate-array-data-provider
branch
from
f669e31 to
e3f2414
Compare
tomivirkki
force-pushed
the
separate-array-data-provider
branch
4 times, most recently
from
c8153cf to
713f230
Compare
tomivirkki
force-pushed
the
separate-array-data-provider
branch
from
4cb44f3 to
004f112
Compare
tomivirkki
commented
Jun 18, 2021
tomivirkki
commented
Jun 18, 2021
Comment on lines
-89
to
+96
| it('should not override custom data provider', () => { | ||
| it('should override custom data provider', () => { |
There was a problem hiding this comment.
Agreed internally that setting grid.items = people is basically a shorthand for setting grid.dataProvider = createArrayDataProvider(people) so setting items should actually override any existing dataProvider
vursen
reviewed
Jun 21, 2021
Co-authored-by: Sergey Vinogradov <[email protected]>
Co-authored-by: Sergey Vinogradov <[email protected]>
Co-authored-by: Sergey Vinogradov <[email protected]>
tomivirkki
force-pushed
the
separate-array-data-provider
branch
from
cc324e3 to
60220b3
Compare
vursen
reviewed
Jun 22, 2021
vursen
approved these changes
Jun 22, 2021
Co-authored-by: Sergey Vinogradov <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
vaadin-grid-array-data-provider-mixin.js, at the end of the day, is just one opinionateddataProviderimplementation. Having the array data provider's codebase mixed in into the GridElement class isn't ideal since it adds unnecessary complexity to the component and makes it difficult to add enhancements related to the array data provider logic (see #1563 for more background).This internal refactor moves the array data provider to an external module (
arrayDataProvider.js) which may later be enhanced as a public feature as suggested in #1563.