Skip to content

ref!: convert internal grid templates to renderers #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 26, 2021
Merged

ref!: convert internal grid templates to renderers #1967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
661073c
ref: convert selection column templates to renderers
vursen May 19, 2021
cd57453
ref: use computed renderers instead of pathOrHeaderChanged observer
vursen May 20, 2021
7f324c5
ref!: render select checkboxes even path property is defined
vursen May 24, 2021
edd5987
ref: convert filter column templates to renderers
vursen May 24, 2021
5dee5ba
fix: address the review comments
vursen May 24, 2021
d81cc51
ref: convert sort column templates to renderers
vursen May 24, 2021
03ebdf6
chore: improve the comments
vursen May 24, 2021
ee9e9c8
ref: convert tree column templates to renderers
vursen May 25, 2021
507361d
test: add more tests
vursen May 25, 2021
f78582b
fix: address the review comments
vursen May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions packages/vaadin-grid/src/vaadin-grid-column.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,24 +80,10 @@ interface ColumnBaseMixin<TItem> {

_prepareTemplatizer(template: HTMLTemplateElement | null, instanceProps: object | null): HTMLTemplateElement | null;

_renderHeaderAndFooter(): void;

_selectFirstTemplate(header?: boolean, footer?: boolean): HTMLTemplateElement | null;

_findTemplate(header: boolean, footer: boolean): HTMLTemplateElement | null;

_pathOrHeaderChanged(
path: string | undefined,
header: string | undefined,
headerCell: HTMLTableCellElement | undefined,
footerCell: HTMLTableCellElement | undefined,
cells: object | undefined,
renderer: GridBodyRenderer<TItem> | null | undefined,
headerRenderer: GridHeaderFooterRenderer<TItem> | null | undefined,
bodyTemplate: HTMLTemplateElement | null | undefined,
headerTemplate: HTMLTemplateElement | null | undefined
): void;

_generateHeader(path: string): string;

_toggleAttribute(name: string, bool: boolean, node: Element): void;
Expand Down
Loading