Skip to content

Conversation

@tomivirkki
Copy link
Member

Fixes to default styles:

  • Make the child elements 100% wide by default
  • Make the component not collapse inside a flex box

@tomivirkki tomivirkki added the no-polymer Removing Polymer from Vaadin public APIs label May 19, 2021
Comment on lines +40 to +41
flex: auto;
align-self: stretch;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styles moved from here

Comment on lines +48 to +50
:host(:not([grid])) #items > ::slotted(*) {
width: 100%;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styles from here

@tomivirkki tomivirkki requested review from vursen and web-padawan May 19, 2021 06:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki tomivirkki merged commit 8fdd470 into master May 19, 2021
@tomivirkki tomivirkki deleted the virtual-list-styles branch May 19, 2021 06:51
vursen pushed a commit that referenced this pull request May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-polymer Removing Polymer from Vaadin public APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants