Skip to content

fix: allow installation with --ignore-script #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Aug 28, 2019

Fixes #42

The workaround is to use magi post-processing so that if user disables "postinstall" script, the export would still work. Opt-out in that case can be still done separately if needed.

So this

import './vaadin-usage-statistics-collect.js';

would become this

export * from './vaadin-usage-statistics-collect.js';

This change is Reviewable

@web-padawan web-padawan merged commit 336cef4 into master Aug 30, 2019
@web-padawan web-padawan deleted the fix-ignore-script branch August 30, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing export with "npm i --ignore-script"
2 participants