Skip to content

fix: check if grid column is attached (#195) #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2021
Merged

fix: check if grid column is attached (#195) #2159

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05dba85
fix: check if grid column is attached (#195)
tulioag Apr 7, 2021
978e216
Fix text for IE11
tulioag Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/vaadin-grid.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,9 @@
}

if (this._columnTree) {
this._columnTree[this._columnTree.length - 1].forEach(c => c.notifyPath && c.notifyPath('_cells.*', c._cells));
this._columnTree[this._columnTree.length - 1].forEach(
(c) => c.isConnected && c.notifyPath && c.notifyPath('_cells.*', c._cells)
);
}

Polymer.RenderStatus.beforeNextRender(this, () => {
Expand Down
9 changes: 9 additions & 0 deletions test/column.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,15 @@
expect(column._bodyTemplate).to.eql(template2);
});
});

it('should not throw an exception when size is changed after removing column', () => {
expect(grid.size).to.equal(10);
expect(column.isConnected).to.be.true;
column.remove();
expect(column.isConnected).to.be.false;
expect(() => (grid.size = 11)).not.to.throw();
expect(grid.size).to.equal(11);
});
});

describe('pro host', () => {
Expand Down