fix: Use offsetWidth for column auto width calculation #1745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
commented
Jun 3, 2020
| @@ -484,7 +484,7 @@ | |||
| col._currentWidth = 0; | |||
| // Note: _allCells only contains cells which are currently rendered in DOM | |||
| col._allCells.forEach(c => { | |||
| const cellWidth = Math.ceil(c.getBoundingClientRect().width); | |||
There was a problem hiding this comment.
element.getBoundingClientRect().width is affected by the visual scaling of the element whereas element.offsetWidth isn't. The original issue was caused by the grid being visually scaled during the dialog opening animation.
web-padawan
approved these changes
Jun 3, 2020
web-padawan
pushed a commit
that referenced
this pull request
Jun 3, 2020
web-padawan
added a commit
that referenced
this pull request
Jun 3, 2020
Co-authored-by: Tomi Virkki <[email protected]>
web-padawan
pushed a commit
that referenced
this pull request
Jun 4, 2020
web-padawan
pushed a commit
that referenced
this pull request
Jun 4, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1723