Don't run renderers for missing header/footer cells #1735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
commented
May 12, 2020
| @@ -235,10 +235,10 @@ | |||
| } | |||
|
|
|||
| _renderHeaderAndFooter() { | |||
| if (this.headerRenderer) { | |||
| if (this.headerRenderer && this._headerCell) { | |||
There was a problem hiding this comment.
Also considered having the check in
- vaadin-grid's
render()but from the grid's point of view, calling_renderHeaderAndFootershould be safe regardless of the column's state. - vaadin-grid-column's
__runRenderer()but the function may expect thecellargument to be defined; it's the responsibility of the caller to make sure the arguments are valid. Otherwise, it wouldn't make sense to have a check forthis.headerRendererhere either.
tomivirkki
force-pushed
the
fix-render-initially-hidden-column
branch
from
05211bf to
5f09803
Compare
pekam
approved these changes
May 13, 2020
web-padawan
pushed a commit
that referenced
this pull request
May 20, 2020
web-padawan
added a commit
that referenced
this pull request
May 22, 2020
Co-authored-by: Tomi Virkki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1729