Calculate column widths on attach #1705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 25, 2020 14:03
|
Missing a test |
tomivirkki
reviewed
Mar 26, 2020
|
Found a synchronous solution for this. We could recalculate the column widths whenever the column set changes: _columnTreeChanged(columnTree, splices) {
...
this.recalculateColumnWidths();
}Might still want to also run on attach though, but that can be sync as well: connectedCallback() {
super.connectedCallback();
this.recalculateColumnWidths();
} |
tomivirkki
approved these changes
Mar 27, 2020
tomivirkki
reviewed
Mar 27, 2020
| @@ -66,7 +67,7 @@ | |||
|
|
|||
| beforeEach(done => { | |||
| grid = fixture('auto-width'); | |||
| sinon.spy(grid, '_recalculateColumnWidths'); | |||
| spy = sinon.spy(grid, '_recalculateColumnWidths'); | |||
There was a problem hiding this comment.
nit: grid._recalculateColumnWidths.reset() would have probably worked fine as well
tulioag
deleted the
fix/906_Flickering_when_recreating_grid_with_GridVariant.LUMO_COMPACT
branch
tulioag
pushed a commit
that referenced
this pull request
Mar 27, 2020
web-padawan
pushed a commit
that referenced
this pull request
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vaadin/vaadin-grid-flow#906