Grid frozen-at-end-column position isn't refreshed correctly when Grid items change

[OlliTietavainenVaadin]

Description

When you have a Grid with one or more frozen columns at the end, and the Grid displays both a vertical and a horizontal scrollbar, applying e.g. a filter to reduce the number of items can cause the vertical scrollbar to disappear. This is currently not causing a recalculation of the frozen column position, but you can trigger the calculation e.g. by moving the horizontal scrollbar a little or resizing the browser window:

Expected outcome

Changing the item list should also recalculate the frozen-to-end column position if needed

Minimal reproducible example

public class HelloWorldView extends HorizontalLayout {


    public HelloWorldView() {
        setSizeFull();
        VerticalLayout layout = new VerticalLayout();
        Grid<String> grid = new Grid<>();
        List<String> letters = new ArrayList<>();
        for (char c = 'a'; c < 'z'; c++) {
            letters.add(c + "");
        }
        GridListDataView<String> stringGridListDataView = grid.setItems(letters);
        Button filterButton = new Button("Filter list");
        filterButton.addClickListener( e-> stringGridListDataView.addFilter( s -> s.equals("a")) );
        layout.add(filterButton);
        grid.addColumn(s -> "Foo").setHeader("Id");
        grid.addColumn(s -> "Bar").setHeader("First name");
        grid.addColumn(s -> "Baz").setHeader("Last name");
        grid.addColumn(s -> "Bizzle").setHeader("Birth date");
        grid.addColumn(s -> "Quux").setHeader("Phone");
        grid.addColumn(s -> "Zyzzyx").setHeader("Address");
        grid.addColumn(p ->"Eius ducimus numquam provident est. Est dolorum odit soluta quia accusamus error fugiat. Alias beatae ut maiores eos.").setHeader("Lorem");
        grid.addComponentColumn(p -> {
            Button button = new Button(LumoIcon.PHONE.create());
            button.addThemeVariants(ButtonVariant.LUMO_ICON);
            return button;
        }).setHeader("Call").setFrozenToEnd(true);
        layout.add(grid);
        add( layout);
    }

}

Steps to reproduce

1. Resize your browser so that the Grid gains a horizontal scrollbar
2. Click the "filter list" button
3. Observe that the frozen column at the end is off by the width of the vertical scrollbar that is no longer there
4. Move the horizontal scrollbar a bit
5. Observe that the frozen column pops in the right place

Environment

Vaadin version(s): 24.4.4
OS: Windows 11

Browsers

Issue is not browser related

[paodb]

The issue is still reproducible in Vaadin 24.8.8.

import com.vaadin.flow.component.button.Button;
import com.vaadin.flow.component.grid.Grid;
import com.vaadin.flow.component.html.Div;
import com.vaadin.flow.component.orderedlayout.HorizontalLayout;
import com.vaadin.flow.component.orderedlayout.VerticalLayout;
import com.vaadin.flow.component.textfield.TextField;
import com.vaadin.flow.data.provider.ListDataProvider;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

public class FrozenToEndTest extends VerticalLayout {

	private static final long rowCount = 25;
	private static final long colCount = 25;

	private Grid<Person> grid;
	private ListDataProvider<Person> dataProvider;
	private final TextField searchField;


	public FrozenToEndTest() {
		searchField = new TextField();
		searchField.setPlaceholder("Suche");
		searchField.setWidth("300px");

		Button searchButton = new Button("Suchen");
		searchButton.addClickListener(e -> performSearch());

		HorizontalLayout searchLayout = new HorizontalLayout(searchField, searchButton);
		searchLayout.setDefaultVerticalComponentAlignment(Alignment.END);

		createGrid();
		add(searchLayout, grid);
		setSizeFull();
		setPadding(true);
		setSpacing(true);
		setFlexGrow(1, grid);
	}


	private void createGrid() {
		grid = new Grid<>(Person.class, false);

		for (int i = 1; i <= rowCount; i++) {
			final int columnIndex = i;
			grid.addColumn(person -> person.getData().get("col" + columnIndex))
					.setHeader("Spalte " + i)
					.setSortable(true)
					.setResizable(true);
		}

		Grid.Column<Person> frozenColumn = grid.addComponentColumn(person -> {
					Div statusDiv = new Div("frozenToEnd");
					statusDiv.getStyle()
							.set("background-color", "#2196F3")
							.set("color", "white")
							.set("text-align", "center")
							.set("padding", "8px")
							.set("width", "100%");
					return statusDiv;
				}).setHeader("frozenToEnd")
				.setWidth("120px")
				.setFlexGrow(0)
				.setFrozenToEnd(true);

		List<Person> dummyData = createDummyData();
		grid.setItems(dummyData);

		grid.setSizeFull();
		grid.setHeight("500px");
	}


	private List<Person> createDummyData() {
		List<Person> persons = new ArrayList<>();

		for (int row = 1; row <= colCount; row++) {
			Person person = new Person();
			for (int col = 1; col <= rowCount; col++) {
				person.getData().put("col" + col, "Wert " + row + "-" + col);
			}
			persons.add(person);
		}

		return persons;
	}

	private void performSearch() {
		String searchTerm = searchField.getValue().trim();

		if (searchTerm.isEmpty()) {
			if (grid.getListDataView().getItems().count() == 0) {
				List<Person> dummyData = createDummyData();
				grid.setItems(dummyData);
			} else {
				grid.setItems();
			}
		} else {
			List<Person> dummyData = createDummyData();
			grid.setItems(dummyData);
		}
	}


	public static class Person {
		private Map<String, String> data = new HashMap<>();

		public Person() {}

		public Map<String, String> getData() {
			return data;
		}

		public void setData(Map<String, String> data) {
			this.data = data;
		}
	}
}