Skip to content

Conversation

Tudor-Barsan
Copy link
Contributor

Implementation Description

  • Hooked up forgotPassword mutation to the reset password button (this sends the email)
  • Added success toast to signify that the email was sent
  • Removed routes and references to RESET_PASSWORD_PAGE

Steps To Test

Question: Should I remove the reset password page since it is no longer referenced? Or should we keep it there?

What Should Reviewers Focus On?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have added tests for my changes
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

github-actions bot commented Aug 25, 2024

Visit the preview URL for this PR (updated for commit d3cb809):

https://feeding-canadian-kids-staging--pr168-reset-password-2al3gd2q.web.app

(expires Mon, 02 Sep 2024 22:55:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f3744353be12c99e3df04fa4e0f28b3ad46bf004

Copy link
Member

@shahanneda shahanneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could we also make the button go into a loading state and be disabled while it tries to send the email? Similar to https://feeding-canadian-kids-staging.web.app/forgot-password

Copy link
Member

@shahanneda shahanneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great work Tudor!

@shahanneda shahanneda merged commit cbcbf3e into main Aug 27, 2024
4 checks passed
@shahanneda shahanneda deleted the reset-password branch August 27, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants