Skip to content

Conversation

ColinToft
Copy link
Collaborator

@ColinToft ColinToft commented Aug 24, 2024

Implementation Description

  • Fixes a couple TODOs in the code

What Should Reviewers Focus On?

  • Biggest thing is that I added back verification of meal statuses. It seems to be working fine but maybe just check that part looks good.

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have added tests for my changes
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

github-actions bot commented Aug 24, 2024

Visit the preview URL for this PR (updated for commit 2b015de):

https://feeding-canadian-kids-staging--pr167-cleanup-todos-i8jpxth0.web.app

(expires Sat, 31 Aug 2024 15:03:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f3744353be12c99e3df04fa4e0f28b3ad46bf004

Copy link
Member

@shahanneda shahanneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing these Colin, did some quick tests and seems to be working well!

@shahanneda shahanneda merged commit f358935 into main Aug 26, 2024
4 checks passed
@shahanneda shahanneda deleted the cleanup-todos branch August 26, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants