Skip to content

Conversation

ColinToft
Copy link
Collaborator

@ColinToft ColinToft commented Aug 21, 2024

Notion Ticket Link

Replace with Ticket URL

Implementation Description

  • Adds admin query to get all meal requests

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have added tests for my changes
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@ColinToft ColinToft marked this pull request as ready for review August 21, 2024 20:18
@ColinToft ColinToft force-pushed the get-meal-requests-query branch from a689969 to 2272af6 Compare August 21, 2024 20:35
@ColinToft ColinToft requested review from ansonjwhe and shahanneda and removed request for ansonjwhe August 21, 2024 20:36
@ColinToft ColinToft self-assigned this Aug 21, 2024
Copy link
Member

@shahanneda shahanneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for doing this one Colin!

@shahanneda shahanneda merged commit b7657db into main Aug 22, 2024
@shahanneda shahanneda deleted the get-meal-requests-query branch August 22, 2024 01:58
Copy link

sentry-io bot commented Aug 27, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Exception: user_id 65d148dc63c7f0f34ae10fd5 not found app.services.implementations.user_service in ge... View Issue
  • ‼️ Exception: The info.involved_meal_requests is negative app.resources.meal_request_dto in __init__ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants