dd: use ibs/obs-sized buffer for skip/seek on non-seekable files #9806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
This was referenced Dec 24, 2025
ChrisDryden
force-pushed
the
fix-dd-no-allocate
branch
from
dd7560f to
289b217
Compare
Collaborator
Author
|
When doing some more benchmarking I found that even if I allocated the buffer the implementation of io::copy capped out at 8kb, a new approach was needed to match the performance characteristics of the GNU implementation |
Contributor
|
needs to be rebased |
ChrisDryden
force-pushed
the
fix-dd-no-allocate
branch
from
289b217 to
3aca9fe
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IBS and OBS flags are supposed to be used to set the size of the memory buffers used by dd. There are tests that validate that the buffers that are allocated are based on these parameters.