Skip to content

Conversation

@ChrisDryden
Copy link
Collaborator

@ChrisDryden ChrisDryden commented Dec 24, 2025

This test makes sure that in a large folder, the memory usage doesn't go up a bunch in this mode. The change itself to fix this is just to add a if check that if its this mode to not store all of the additional metadata since there's no need to use it later.

@ChrisDryden ChrisDryden force-pushed the fix-cp-link-heap-memory branch from d4a9dc4 to ee0d7e3 Compare December 24, 2025 02:17
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 24, 2025

CodSpeed Performance Report

Merging #9805 will not alter performance

Comparing ChrisDryden:fix-cp-link-heap-memory (77a16f1) with main (2d718f2)

Summary

✅ 127 untouched
⏩ 6 skipped1

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/cp/link-heap is no longer failing!

@ChrisDryden ChrisDryden marked this pull request as ready for review December 24, 2025 02:37
@ChrisDryden
Copy link
Collaborator Author

As a note for this one, we need to come up with a framework for testing memory usage similar to codspeed so that we can verify that we don't introduce regressions that use more memory than required. I don't think codspeed currently supports it but it looks like its on its roadmap to be supported soon

@sylvestre sylvestre merged commit 27fd411 into uutils:main Jan 9, 2026
128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants