-
Notifications
You must be signed in to change notification settings - Fork 19
Add Ionospheric Delay to GNSS Receiver #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/gnss-receiver-update
Are you sure you want to change the base?
Add Ionospheric Delay to GNSS Receiver #763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コメントつけました。
double azimuth_rad = elevation_azimuth_rad[0]; | ||
double elevation_rad = elevation_azimuth_rad[1]; | ||
|
||
double earth_centered_angle_semi = 0.0137 / (elevation_rad * rad2semi + 0.11) - 0.022; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[WANT] これは、こちらに定義するのが良いかなと思います。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この値はelevation_radに応じて変化するので定数として定義できないと思うのですがいかがでしょうか。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fukudakazuya こちらのコメント確認をお願いします。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@200km すみません、pendingになっていて返信できていませんでした。
earth_centered_angle_semi
はelevation_radに応じて変化するので定数として定義できないと思うのですがいかがでしょうか。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確かにそうですね。
でしたら、この式の中に入っているマジックナンバーを説明するコメントや参照などを書いてもらえると嬉しいです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
298行目に
// Ref: Klobuchar, J.A., (1996) "Ionosphercic Effects on GPS", in Parkinson, Spilker (ed), "Global Positioning System Theory and Applications,
// pp.513-514.
と一応参照を入れていますが、不十分でしょうか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可読性を考えると、マジックワードの近くにより細かな数値の意味を書いてもらえると嬉しいです。
例えば、「参考資料の式***参照」などあると便利だと思います。(英語で書いてもらいたいですが)
コメントありがとうございました。修正したので確認よろしくお願いいたします。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一つだけ、前回指摘分が残っているので確認をお願いします。それ以外は問題ないです。
Related issues
#600
Description
Test results
L1, L2, L5それぞれの電離層遅延量



L1の疑似距離、搬送波位相


MATLABですでに実装、公開されているコードを実行し、同じinputで以下の計算値が同じになることを確認した。
input
klobuchar_alpha_[0] = 3.82E-8; klobuchar_alpha_[1] = 1.49E-8; klobuchar_alpha_[2] = -1.79E-7; klobuchar_alpha_[3] = 0.0; klobuchar_beta_[0] = 1.43E5; klobuchar_beta_[1] = 0.0; klobuchar_beta_[2] = -3.28E5; klobuchar_beta_[3] = 1.13E5; elevation_rad = 20.0 * math::deg_to_rad; azimuth_rad = 210.0 * math::deg_to_rad; receiver_latitude_rad = 40.0 * math::deg_to_rad; receiver_longitude_rad = 260.0 * math::deg_to_rad; gps_time_s_ = 593100.0;
S2Eの計算結果
earth_centered_angle_semii: 0.039960 latitude_ipp_semi: 0.187616 longitude_ipp_semi: 1.420409 geomagnetic_latitude_ipp_semi: 0.239793 local_time_ipp_s: 49661.667431 slant_factor: 2.176025 ionospheric_delay_gps_l1_m/c_m_s: 0.0000000793
MATLABの計算結果
psi = 0.03996 lat_i = 0.18762 long_i = 1.4204 lat_m = 0.23979 t = 49661.6674 sF = 2.176 dIon1 = 7.9335e-08
Impact
Describe the scope of influence of the changes, e.g.,
The behavior of feature ** changes.
Supplementary information
Provide any supplementary information.