Skip to content

"Added UI visualization for important fields in user create in platform client. #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2020

Conversation

noone0212
Copy link
Contributor

@noone0212 noone0212 commented Mar 12, 2020

This pull request makes the following changes:

  • Added UI visualization for important fields in user create in platform client.

Testing checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform#2105 .

Ping @ushahidi/platform

@ushbot
Copy link
Collaborator

ushbot commented Mar 12, 2020

Hey @noone0212,
thank you for your Pull Request.

It looks like you haven't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@noone0212
Copy link
Contributor Author

clabot:check

Copy link
Contributor

@rowasc rowasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works great.
Thank you so much 🎉

@Angamanga Angamanga merged commit 4f0b616 into ushahidi:develop Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No specific UI feedback on "Display name" missing while creating a new user, except for save button being disabled
4 participants