[USH-1699] Identify unlocalized strings in the web client and add them to en.json #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icker, default settings header
…d polling service
Angamanga
approved these changes
Dec 10, 2024
| { displayNane: this.translate.instant('activity.categories'), value: 'tags' }, | ||
| { displayNane: this.translate.instant('activity.survey'), value: 'form' }, | ||
| { displayNane: this.translate.instant('activity.status'), value: 'status' }, | ||
| ]; |
There was a problem hiding this comment.
Is it actually called displayNane? :D I see it was called that before too, maybe we should change it to displayName, or am I missing something important?
There was a problem hiding this comment.
Ah yes, I should change that. I almost thought it was named like that on purpose but I can still change it :)
There was a problem hiding this comment.
Actually, when thinking about it, its for the activity-view that is most likely going to change very soon, so lets leave it as it. Its out of scope for this ticket :)
There was a problem hiding this comment.
Aah ok, actually I have already made the changes, but I think we can leave it at that
tuxpiper
pushed a commit
that referenced
this pull request
Jan 7, 2025
…m to en.json (#1494) * Translations - Breadcrumbs * Translations - Login/Authentication * Translations: Post timelines, posts loading message, date shows up here text * Reverting timeline translations for now * Translation: OK Button, Uploading, Activty View * Translation: Data source subheading * Slight adjustment to solve 'Add webhook' json file conflicts * Translations: Survey & General Confirm Modal, snackbar, Survey Colorpicker, default settings header * Translations: Activity page * Translations: Adding more strings into en.json for map view options * Translations: Onboarding modals * Translations: Sources Filters * Translations: Timelines for post metadata and post conversations * Just a slight fix * Translations: showError() in survey-item, user-settings components and polling service * Translations: Close button in all snackbars * Translations: Location Select strings * Translations: Image uploader special characters text * Translations: Post edit component * Translations: Post not authorized to edit * Translations: Remaining strings * Renamed 'displayNane' to 'displayName'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.