Skip to content

USH-1686 - Cutoff posts for empty images #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

USH-1686 - Cutoff posts for empty images #1479

merged 1 commit into from
Nov 21, 2024

Conversation

ushahidlee
Copy link
Contributor

Issue:

Posts that use the old image field, are cutoff when no image was uploaded.

Solution:

This PR adds some minor sanity checks to prevent this from happening.

Testing:

  1. Create a post in a survey that uses the old image field, but importantly this field cannot be the last one in the post. Make sure there are fields filled in after the image field and that the image field itself is empty (no file uploaded).
  2. Open the post in detail view.
  3. See that all fields are included in the view and the post is not cutoff.

@ushahidlee ushahidlee requested a review from Angamanga November 21, 2024 10:10
@linear Linear
Copy link

linear bot commented Nov 21, 2024

USH-1686 Post details are being cut off for some posts

Angamanga
Angamanga approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this even work before :D Approved!

@ushahidlee ushahidlee merged commit d29a6bf into development Nov 21, 2024
10 of 12 checks passed
tuxpiper pushed a commit that referenced this pull request Nov 26, 2024
@ushahidlee @tuxpiper
Fix cutoff posts for empty images (#1479)
85f425c
Angamanga pushed a commit that referenced this pull request Nov 27, 2024
@ushahidlee @Angamanga
Fix cutoff posts for empty images (#1479)
35f603a
tuxpiper pushed a commit that referenced this pull request Nov 27, 2024
@ushahidlee @tuxpiper
Fix cutoff posts for empty images (#1479)
91bc206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angamanga Angamanga Angamanga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ushahidlee @Angamanga