Skip to content

USH-1683 - Posts not submitting for surveys with the old image field #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

ushahidlee
Copy link
Contributor

Issue:

For surveys with the previous image field, posts fail to submit if an image is not uploaded.

Solution:

A tiny little fix that presents an empty array, rather than a null value in the field values.

Ticket:

https://linear.app/ushahidi/issue/USH-1683/posts-not-submitting-for-surveys-that-already-had-image-field#comment-03592f34

Testing:

  1. Create a survey with an old image field.
  2. Create a new post of the above survey, but without uploading an image.
  3. Submit the post successfully.

@ushahidlee ushahidlee requested a review from Angamanga November 20, 2024 12:46
Copy link

linear bot commented Nov 20, 2024

Copy link
Contributor

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@ushahidlee ushahidlee merged commit 6a15bd7 into development Nov 20, 2024
10 of 12 checks passed
tuxpiper pushed a commit that referenced this pull request Nov 20, 2024
tuxpiper pushed a commit that referenced this pull request Nov 26, 2024
Angamanga pushed a commit that referenced this pull request Nov 27, 2024
tuxpiper pushed a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants