Using only-parameters for surveys #1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushahidlee
reviewed
Oct 18, 2024
| this.getPostAllowedTypes(); | ||
| private getSurveys(): void { | ||
| this.surveysService | ||
| .getSurveys('', { only: 'name,color,everyone_can_create,can_create' }) |
There was a problem hiding this comment.
maybe the string literal should be in a constant file?
ushahidlee
approved these changes
Oct 18, 2024
|
@ushahidlee And done! Moved the strings to the apiHelper, I think that makes sense since they will be the same in the mobile-app probably... |
tuxpiper
pushed a commit
that referenced
this pull request
Nov 10, 2024
* Using only-parameters for adding a post * Using only-parameter for filter-bar for surveys * Using only-parameters for survey-settings * Using only-parameters for data-import * moving strings to helper-file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to use only-parameters for surveys for:
To test: Smoke-test on above functionalities, they should work as before 😬