Feature/rename refactoring/parametric impl #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PieterOlivier
force-pushed
the
feature/rename-refactoring/parametric-impl
branch
from
6711f29 to
803dc0d
Compare
DavyLandman
requested changes
Aug 11, 2025
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/DefaultWorkspaceService.java
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/BaseWorkspaceService.java
Show resolved
Hide resolved
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/BaseWorkspaceService.java
Outdated
Show resolved
Hide resolved
...-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/InterpretedLanguageContributions.java
Outdated
Show resolved
Hide resolved
...-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/InterpretedLanguageContributions.java
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParametricTextDocumentService.java
Show resolved
Hide resolved
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParserOnlyContribution.java
Outdated
Show resolved
Hide resolved
|
|
||
| let renameSuccess = false; | ||
| let tries = 0; | ||
| while (!renameSuccess && tries < 5) { |
There was a problem hiding this comment.
this loop is a copy of something in the ide.test.ts, how about we factor that out into a function in our ide class? (just like we did for move)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements rename refactoring from the design in PR #651
Point of discussion: