Skip to content

Fix document symbol crash on ambiguous declaration #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2025

Conversation

toinehartman
Copy link
Member

Prevent crash of document symbols computation when a top level declaration ambiguous

Closes #560

@toinehartman toinehartman self-assigned this Aug 6, 2025
@toinehartman toinehartman added the bug Something isn't working label Aug 6, 2025
@toinehartman
Copy link
Member Author

Tagging @jurgenvinju since this solution was originally proposed by you in #560

Copy link
Contributor

@PieterOlivier PieterOlivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a sensible fix to me.

Copy link

@DavyLandman DavyLandman merged commit 42afd7a into main Aug 12, 2025
14 checks passed
@toinehartman toinehartman deleted the fix/560-ambiguous-document-symbol branch August 12, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some (but not all) ambiguity errors make Rascal Document Symbols crash
3 participants