Skip to content

Conversation

@abhishek-bruno
Copy link
Contributor

@abhishek-bruno abhishek-bruno commented Nov 4, 2025

Description

Enhancement PR for #5722

Changes:

  • Removed reorderDirectoryItems helper function
  • Moved reordering logic directly inside deleteItem action
  • Removed the logic of reorder in DeleteCollectionItem component
  • Kept error handling with improved error message display
  • Added proper error rejection in promises where it is missing

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@abhishek-bruno abhishek-bruno changed the title Refactor: Enhanced PR #5722 Refactor: Enhance Request Item sequencing Nov 4, 2025
@bijin-bruno bijin-bruno changed the base branch from fix/reorder-items-when-deleting to main November 13, 2025 11:40
@pull-request-size pull-request-size bot added size/S and removed size/M labels Nov 13, 2025
@bijin-bruno bijin-bruno reopened this Nov 13, 2025
Copy link
Collaborator

@bijin-bruno bijin-bruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhishek-bruno Please add a playwright test for this.

@abhishek-bruno abhishek-bruno force-pushed the fix/reorder-item-when-deleting-v2 branch from 5848c32 to 73f5179 Compare November 17, 2025 08:10
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 17, 2025
@abhishek-bruno abhishek-bruno force-pushed the fix/reorder-item-when-deleting-v2 branch from dbe8b83 to 3f7ab31 Compare November 17, 2025 10:36
@bijin-bruno bijin-bruno merged commit e613e4c into usebruno:main Nov 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants