Skip to content

Conversation

tz850
Copy link

@tz850 tz850 commented Jul 6, 2020

for #351

@jingwood
Copy link
Member

jingwood commented Jul 7, 2020

Thanks! I have modified this pull request to process empty cells.
I think we should output the empty cells like a,b,,c rather than insert a space a,b, ,c.

And after some check, I found the original export logical is too simple and is not enough to process cell value which contains double quotes or commas, the code also has been improved.

There is a todo on how correctly read from CSV format when values contain double quotes or commas.

Refer to csv format on wikipedia

@jingwood jingwood merged commit f160ff1 into unvell:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants