Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Llama4 MoE Grouped GEMM
Add a reference
Llama4TextMoe
layer that uses the grouped gemm kernel from #2465.Note that due to structural differences from
Qwen3
and more typical MoE architectures, some of the fusions from the original implementation are not applicable.Also, there are additional optimization opportunities around the router, token shuffling, and shared expert calculation to be added in future PRs.
Updates:
tests/test_llama4_moe.py
- correctness tests for theLlama4
triton grouped gemm layer.benchmark/benchmark_fused_moe.py
- updated to includeLlama4
in additional toQwen3
.grouped_gemm/reference/layers/llama4_moe.py
- implementation of HFLlama4TextMoe
with triton grouped gemm kernel.