After updating to 6.1.23 the `SetWindowIcon` is not available on plain .NET target and VS shows error for Uno targets

[xperiandri]

Current behavior

SetWindowIcon is not available for plain .NET target (net9.0)

Expected behavior

SetWindowIcon is generated for all targets

How to reproduce it (as minimally and precisely as possible)

1. Create a project from the template.
2. Change to <TargetFrameworks>net9.0-windows10.0.26100;net9.0-browserwasm;net9.0-desktop;net9.0</TargetFrameworks>

Environment

Package Version(s): 6.1.23

Affected platform(s):

• iOS
• Android
• WebAssembly
• Desktop

Visual Studio:

• 2022 (version: 17.14.9)

Anything else we need to know?

A clean project from the template displays an error in VS with
<TargetFrameworks>net9.0-windows10.0.26100;net9.0-browserwasm;net9.0-desktop</TargetFrameworks>
and build fails with
<TargetFrameworks>net9.0-windows10.0.26100;net9.0-browserwasm;net9.0-desktop;net9.0</TargetFrameworks>

My solution

[xperiandri]

@jeromelaban what is the correct approach now?
I had a solution with tests from some previous template that I upgraded to 6.1

[jeromelaban]

@xperiandri this should not be causing issues a build, but only in intellisense. Is it the case?

Still this is incorrect and should not be visually failing.

[xperiandri]

@jeromelaban if I create the blank app from the template with tests enabled then I will get the same Uno app configuration as I have in my project. And it will fail building net9.0 target. So my question is how do you recommend to deal with that?
You removed the generation of SetWindowIcon from the generic target. Now the template is broken.
I can put #if and fix this issue for my case but what about everyone else getting the same build issue and newcomers?

[jeromelaban]

Got it, thanks for the update. Yes, you can put a #if around, that extension should be generated for net9.0 but clearly isn't.

[jeromelaban]

While we're at fixing this one, let's also fix unoplatform/uno#20550. The API does not need to be public or marked as not exposed.

[xperiandri]

So, for now, this same line is enough, as it is only relevant for WinUI

uno.resizetizer/src/Resizetizer/Resizetizer.Generators/WindowTitleGenerator.cs

Line 128 in e74e903

w.AppendUnindentedLine("#if WINDOWS && !HAS_UNO");