Cannot "Reset" a property in a new default app

[mrlacey]

Current behavior

At one point I got an error message briefly displayed in the corner of the screen about a failure to update the XAML, this wasn't reported to the output window (of VS) so I don't know how to retrieve it or see it again to look at exactly what went wrong. Is there any way to copy these messages?

Expected behavior

• XAML updating scenarios should all work.
• Don't change the running app if the XAML update fails.
• Indicate when/if the displayed app doesn't reflect the current XAML.

Which tool(s) are affected?

Hot Design™

How to reproduce it (as minimally and precisely as possible)

Simple XAML update issue with very basic repro:

- With newly created default app in HD mode:
- Select button
- in Properties tab, open the extended menu for the Content.
- Click "Reset"
- See XAML fails to update
- Feel very sad :(

This is what's shown in the image above

Workaround

No response

Affected platforms

Desktop (Skia)

Uno.Sdk version

5.6.22

IDE used

Visual Studio 2022

IDE version

7.13.0 Preview 5.0

Uno Platform Extension version

5.6.15.19

Relevant plugins

No response

Anything else we need to know?

Originally from #53

[nickrandolph]

Two points for investigation:

• Why did reset not work
• Why did the revert (what happens when attempting to set xaml fails) not restore the UI of the app

[mrlacey]

Here's the output from the console window

The specified framework 'Microsoft.WindowsDesktop.App' is not present in the previously loaded runtime.
fail: Uno.UI.HotDesign.XamlFileModifier[0]
Error in TryRemoveParameter: System.IndexOutOfRangeException: Index was outside the bounds of the array.
at Uno.UI.HotDesign.XamlFileModifier.TryRemoveParameter(String fileLocationIdentifier, String parameterName, Boolean isContentProperty, String& message)
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at Uno.UI.HotDesign.XamlFileModifier.TryRemoveParameter(String fileLocationIdentifier, String parameterName, Boolean isContentProperty, String& message)
fail: Uno.UI.HotDesign.Client.AppUpdater[0]
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at Uno.UI.HotDesign.XamlFileModifier.TryRemoveParameter(String fileLocationIdentifier, String parameterName, Boolean isContentProperty, String& message)

[mrlacey]

Looks like an issue handling properties wrapped over multiple lines.

Don't get an issue if everything is on one line.

<Button AutomationProperties.AutomationId="SecondPageButton" Command="{Binding GoToSecond}" Content="Go to Second Page" />

It does not work if over multiple lines and use tabs to indent.

<Button
	AutomationProperties.AutomationId="SecondPageButton"
	Command="{Binding GoToSecond}"
	Content="Go to Second Page" />

it does work if over multiple lines and use spaces to indent.

<Button
    AutomationProperties.AutomationId="SecondPageButton"
    Command="{Binding GoToSecond}"
    Content="Go to Second Page" />

If put everything on one line and use tabs to separate attributes of an element then get a different error.

<Button	AutomationProperties.AutomationId="SecondPageButton"	Command="{Binding GoToSecond}"	Content="Go to Second Page" />

From the console log

fail: Uno.UI.HotDesign.XamlQuerier[0]
      Failure in TryGetOriginalXamlStringAsync(Button 31#6/ (60685926))
      System.Xml.XmlException: 'D' is an unexpected token. Expecting whitespace. Line 31, position 90.
         at System.Xml.XmlTextReaderImpl.Throw(Exception e)
         at System.Xml.XmlTextReaderImpl.Throw(String res, String arg)
         at System.Xml.XmlTextReaderImpl.ParseAttributes()
         at System.Xml.XmlTextReaderImpl.ParseElement()
         at System.Xml.XmlTextReaderImpl.ParseElementContent()
         at Uno.UI.HotDesign.XamlQuerier.InnerTryGetOriginalXamlString(ElementIdentifier elementId, Boolean lookupOutDetails, XElement& element, String& qualifiedElementName, String& filePath, Int32& xmlStartLineNumber, Int32& xmlStartLinePosition, Int32& xmlEndLineNumber, Int32& xmlEndLinePosition, String& message)
fail: Uno.UI.HotDesign.Client.XamlUpdates.ShadowXamlDom[0]
      Failed to get original XAML from Shadow XD for element 'D:/source/HDTest/UnoApp1/UnoApp1/Presentation/MainPage.xaml#L31:6Button60685926'. Error: 'D' is an unexpected token. Expecting whitespace. Line 31, position 90.   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
         at System.Xml.XmlTextReaderImpl.Throw(String res, String arg)
         at System.Xml.XmlTextReaderImpl.ParseAttributes()
         at System.Xml.XmlTextReaderImpl.ParseElement()
         at System.Xml.XmlTextReaderImpl.ParseElementContent()
         at Uno.UI.HotDesign.XamlQuerier.InnerTryGetOriginalXamlString(ElementIdentifier elementId, Boolean lookupOutDetails, XElement& element, String& qualifiedElementName, String& filePath, Int32& xmlStartLineNumber, Int32& xmlStartLinePosition, Int32& xmlEndLineNumber, Int32& xmlEndLinePosition, String& message)
fail: Uno.UI.HotDesign.XamlQuerier[0]
      Failure in TryGetOriginalXamlStringAsync(Button 31#6/ (60685926))
      System.Xml.XmlException: 'D' is an unexpected token. Expecting whitespace. Line 31, position 90.
         at System.Xml.XmlTextReaderImpl.Throw(Exception e)
         at System.Xml.XmlTextReaderImpl.Throw(String res, String arg)
         at System.Xml.XmlTextReaderImpl.ParseAttributes()
         at System.Xml.XmlTextReaderImpl.ParseElement()
         at System.Xml.XmlTextReaderImpl.ParseElementContent()
         at Uno.UI.HotDesign.XamlQuerier.InnerTryGetOriginalXamlString(ElementIdentifier elementId, Boolean lookupOutDetails, XElement& element, String& qualifiedElementName, String& filePath, Int32& xmlStartLineNumber, Int32& xmlStartLinePosition, Int32& xmlEndLineNumber, Int32& xmlEndLinePosition, String& message)
fail: Uno.UI.HotDesign.Client.XamlUpdates.ShadowXamlDom[0]
      Failed to get original XAML from Shadow XD for element 'D:/source/HDTest/UnoApp1/UnoApp1/Presentation/MainPage.xaml#L31:6Button60685926'. Error: 'D' is an unexpected token. Expecting whitespace. Line 31, position 90.   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
         at System.Xml.XmlTextReaderImpl.Throw(String res, String arg)
         at System.Xml.XmlTextReaderImpl.ParseAttributes()
         at System.Xml.XmlTextReaderImpl.ParseElement()
         at System.Xml.XmlTextReaderImpl.ParseElementContent()
         at Uno.UI.HotDesign.XamlQuerier.InnerTryGetOriginalXamlString(ElementIdentifier elementId, Boolean lookupOutDetails, XElement& element, String& qualifiedElementName, String& filePath, Int32& xmlStartLineNumber, Int32& xmlStartLinePosition, Int32& xmlEndLineNumber, Int32& xmlEndLinePosition, String& message)
warn: Uno.UI.HotDesign.Client.AppUpdater[0]
      Failed to SET local property: object not found at path.
fail: Uno.UI.HotDesign.XamlQuerier[0]
      Failure in TryGetOriginalXamlStringAsync(Button 31#6/ (60685926))
      System.Xml.XmlException: 'D' is an unexpected token. Expecting whitespace. Line 31, position 90.
         at System.Xml.XmlTextReaderImpl.Throw(Exception e)
         at System.Xml.XmlTextReaderImpl.Throw(String res, String arg)
         at System.Xml.XmlTextReaderImpl.ParseAttributes()
         at System.Xml.XmlTextReaderImpl.ParseElement()
         at System.Xml.XmlTextReaderImpl.ParseElementContent()
         at Uno.UI.HotDesign.XamlQuerier.InnerTryGetOriginalXamlString(ElementIdentifier elementId, Boolean lookupOutDetails, XElement& element, String& qualifiedElementName, String& filePath, Int32& xmlStartLineNumber, Int32& xmlStartLinePosition, Int32& xmlEndLineNumber, Int32& xmlEndLinePosition, String& message)
fail: Uno.UI.HotDesign.Client.XamlUpdates.ShadowXamlDom[0]
      Failed to get original XAML from Shadow XD for element 'D:/source/HDTest/UnoApp1/UnoApp1/Presentation/MainPage.xaml#L31:6Button60685926'. Error: 'D' is an unexpected token. Expecting whitespace. Line 31, position 90.   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
         at System.Xml.XmlTextReaderImpl.Throw(String res, String arg)
         at System.Xml.XmlTextReaderImpl.ParseAttributes()
         at System.Xml.XmlTextReaderImpl.ParseElement()
         at System.Xml.XmlTextReaderImpl.ParseElementContent()
         at Uno.UI.HotDesign.XamlQuerier.InnerTryGetOriginalXamlString(ElementIdentifier elementId, Boolean lookupOutDetails, XElement& element, String& qualifiedElementName, String& filePath, Int32& xmlStartLineNumber, Int32& xmlStartLinePosition, Int32& xmlEndLineNumber, Int32& xmlEndLinePosition, String& message)

[nickrandolph]

@mrlacey thanks for the additional information here. The root cause was the positioning of the sxid which was broken in the case where only tabs were used as spacers between elements.